Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39585

All filters disabled after 2.4 to 2.5 upgrade

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Filters
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: medium (requires site upgrade)

      1. Prepare (new or existing) recent Moodle 2.4.3+ site.
      2. Enable some text filters and override some of them at the course context.
      3. Upgrade the site to the recent 2.5
      4. TEST: Make sure the filters configuration has not changed.

      Show
      Testing difficulty: medium (requires site upgrade) 1. Prepare (new or existing) recent Moodle 2.4.3+ site. 2. Enable some text filters and override some of them at the course context. 3. Upgrade the site to the recent 2.5 4. TEST: Make sure the filters configuration has not changed.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39585-filters-upgrade

      Description

      Observed problem:

      After the recent 2.4 -> recent 2.5 upgrade, all filters are disabled. More than that, there are invalid obsolete records for legacy filer names displayed (like "filter/tex") as missing and the new ones (like "tex") are disabled.

      Reason:

      Early in 2.5dev cycle, the upgrade step was introduced to convert legacy filter names (like "filter/tex") to new ones (like "tex") - see patch 0662bd677ca44bdd20b883a2c106ffc56f0574e8 (MDL-29996). This upgrade step was using the stable-like versioning:

      if ($oldversion < 2012120300.07) {
      

      but was integrated on master only (thence did not following the on-sync policy).

      Because now, the stable version number is higher than that upgrade step, it is not executed which causes the observed behaviour.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13