Moodle
  1. Moodle
  2. MDL-38856 META: Issues around Bootstrapbase and Clean theme
  3. MDL-39595

Change core.php to core_renderer.php in bootstrapbase/renderers

        Details

        • Type: Sub-task Sub-task
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.5
        • Fix Version/s: 2.5
        • Component/s: Themes
        • Labels:
        • Rank:
          50285

          Description

          The name of this renderer file should have been changed ages ago.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Mary Evans added a comment -

            Just adding you as a watcher Tim.

            Show
            Mary Evans added a comment - Just adding you as a watcher Tim.
            Hide
            Permalink
            David Scotson added a comment - - edited

            From the description in the forum (https://moodle.org/mod/forum/discuss.php?d=228209) it sounds like we could delete the renderers.php file after this filename is changed.

            edit: reading further it seems the change that makes it work without the renderers.php file isn't integrated yet so removing that file should be a seperate issue/task that is done after that is integrated. But the rename can happen now in preperation.

            Show
            David Scotson added a comment - - edited From the description in the forum ( https://moodle.org/mod/forum/discuss.php?d=228209 ) it sounds like we could delete the renderers.php file after this filename is changed. edit: reading further it seems the change that makes it work without the renderers.php file isn't integrated yet so removing that file should be a seperate issue/task that is done after that is integrated. But the rename can happen now in preperation.
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Permalink
            Mary Evans added a comment -

            Rebased thanks!

            Show
            Mary Evans added a comment - Rebased thanks!
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Just!

            Show
            Sam Hemelryk added a comment - Just!
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Tested and passed during integration review

            Show
            Sam Hemelryk added a comment - Tested and passed during integration review
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Just In Time® for stable releases, thanks!

            Closing as fixed, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Just In Time® for stable releases, thanks! Closing as fixed, ciao

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: