Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:

      Description

      The name of this renderer file should have been changed ages ago.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            lazydaisy Mary Evans added a comment -

            Just adding you as a watcher Tim.

            Show
            lazydaisy Mary Evans added a comment - Just adding you as a watcher Tim.
            Hide
            bawjaws David Scotson added a comment - - edited

            From the description in the forum (https://moodle.org/mod/forum/discuss.php?d=228209) it sounds like we could delete the renderers.php file after this filename is changed.

            edit: reading further it seems the change that makes it work without the renderers.php file isn't integrated yet so removing that file should be a seperate issue/task that is done after that is integrated. But the rename can happen now in preperation.

            Show
            bawjaws David Scotson added a comment - - edited From the description in the forum ( https://moodle.org/mod/forum/discuss.php?d=228209 ) it sounds like we could delete the renderers.php file after this filename is changed. edit: reading further it seems the change that makes it work without the renderers.php file isn't integrated yet so removing that file should be a seperate issue/task that is done after that is integrated. But the rename can happen now in preperation.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            lazydaisy Mary Evans added a comment -

            Rebased thanks!

            Show
            lazydaisy Mary Evans added a comment - Rebased thanks!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Just!

            Show
            samhemelryk Sam Hemelryk added a comment - Just!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Tested and passed during integration review

            Show
            samhemelryk Sam Hemelryk added a comment - Tested and passed during integration review
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Just In Time® for stable releases, thanks!

            Closing as fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Just In Time® for stable releases, thanks! Closing as fixed, ciao

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13