I know on the original issue David mentioned that the @horizontalComponentOffset var wasn't used, but it is indeed used in other places else where, which is why I have left it as it is currently, while adding @horizontalComponentOffset1200 to handle the bigger size screens.

Requesting peer review now.

I've not tested it yet but from looking at the diff the current 768 level doesn't seem to do anything and all the related code can be deleted without affecting anything as the labels are already set to that width by default.

Can some one please review this? I've adjusted it in response to David's comment above.

@Jason, there is a problem in MDL-39820 where the margins are way too wide.

If you look at base theme the label left margins are set to 15% which in for 960px through to 2000px is from between 144px to 300px. Compare this with Bootstrapbase where @horizontalComponantOffset768: and @horizontalComponantOffset980: sets label margins at anywhere between 220px and 265px for screen 768px to 980px respectively. Which is OTT in my estimation.

We might just do a quick fix with MDL-39820 and wait till you have this fixed.

By the way what you have here looks better. I think is good to go.

Thanks Mary, pushing for integration now then.

Dear Jason Fowler,

As this is a bug will there be a MOODLE_25_STABLE branch too for the fix?

Cheers,

Gareth

@Gareth, they will most probably cherry-pick to M25 during integration, since it is only affecting LESS files. Guessing so anyway!

I hope so

Gareth: yes, while 2.5 and master are sync'd, any issues for master are always backported off the master branch. They will be sync'd until 2.5.1 is released.

Dear Jason Fowler,

Thanks - did not know that

Cheers,

Gareth

Thanks Jason, this has been integrated now.

Tested during integration review and passed.

Thanks Sam

FYI, in Bootstrap v3 they achieve this natively, by using the standard grid for laying out forms, so you get e.g. 4/12 for the labels and 8/12 for the control (where you can choose your own values for 4&8) which expand with the container and it collapses to stacked forms at the standard grid breakpoint.

Thanks for your awesome work! This has now become a part of Moodle.

Closing as fixed!