Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39618

Missing string [[cannotcreatedb]] (backport of MDL-39575)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4.3
    • Fix Version/s: 2.4.8
    • Component/s: Installation
    • Labels:
    • Testing Instructions:
      Hide
      1. Start a fresh installation.
      2. Select MySQL.
      3. Specify a database that doesn't exist.
      4. Specify a user who doesn't have permission to create a database. (verify this on the command line first)
      5. Proceed.
      6. Check you get an proper message rather than [[cannotcreatedb]]
      Show
      Start a fresh installation. Select MySQL. Specify a database that doesn't exist. Specify a user who doesn't have permission to create a database. (verify this on the command line first) Proceed. Check you get an proper message rather than [ [cannotcreatedb] ]
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE

      Description

      This is a bout to backport MDL-39575 to stable supported branches, by applying the solution that was applied to master (1168a5f).

      Easy to find:

      1. Create a MySQL user who can log in but does not have permission to create a database.
      2. Start a fresh Moodle installation (no config.php present).
      3. Try and use the credentials of the MySQL user above.
      4. You'll get an error [[cannotcreatedb]] instead of a string.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment - - edited

              As a bug, I don't think this needs a vote??

              Show
              poltawski Dan Poltawski added a comment - - edited As a bug, I don't think this needs a vote??
              Hide
              poltawski Dan Poltawski added a comment -

              This issue has been voted on by the integration team, and we'd like to see this issue backported asap

              Thanks!

              Show
              poltawski Dan Poltawski added a comment - This issue has been voted on by the integration team, and we'd like to see this issue backported asap Thanks!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Ping, any news here?

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Ping, any news here?
              Hide
              poltawski Dan Poltawski added a comment -

              Taking this since it seems straight forward.

              Show
              poltawski Dan Poltawski added a comment - Taking this since it seems straight forward.
              Hide
              poltawski Dan Poltawski added a comment -

              I tested sams patch against 24 and it seems to work fine - so submitting this straight for integration (was peer reviewed on the original issue)

              Show
              poltawski Dan Poltawski added a comment - I tested sams patch against 24 and it seems to work fine - so submitting this straight for integration (was peer reviewed on the original issue)
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              marina Marina Glancy added a comment -

              Thanks Dan, integrated in 2.4

              Show
              marina Marina Glancy added a comment - Thanks Dan, integrated in 2.4
              Hide
              phalacee Jason Fowler added a comment -

              Thanks Dan, problem solved.

              Show
              phalacee Jason Fowler added a comment - Thanks Dan, problem solved.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks for the code, its now upstream!

              Heres a fun trick to try in the spirit of Friday the 13th.
              I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks for the code, its now upstream! Heres a fun trick to try in the spirit of Friday the 13th. I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14