Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39694 META: Colour trend improvements to Formal White theme
  3. MDL-39626

It would be nice to have in formal_white a color selector for background images too

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Choose formal_white as your theme.
      2. Go to formal_white settings page.
      3. Use the "Trend colour" drop down menu to select a colour.
      4. Submit the theme settings page and you should see the changes almost instantly as the cache is purged automatically.
      5. Test that the outer frame rounded corners, together with page background, navigation bar, custom-menu, block header elements change colour according to your selection. (see attached coloured screen-shot images)
      6. Test also that text-wrap block titles have coloured backgrounds when the header area is deeper.
      7. Test also quiz/course and frontpage course listing headers share the same 'trend' colour.
      Show
      Choose formal_white as your theme. Go to formal_white settings page. Use the "Trend colour" drop down menu to select a colour. Submit the theme settings page and you should see the changes almost instantly as the cache is purged automatically. Test that the outer frame rounded corners, together with page background, navigation bar, custom-menu, block header elements change colour according to your selection. (see attached coloured screen-shot images) Test also that text-wrap block titles have coloured backgrounds when the header area is deeper. Test also quiz/course and frontpage course listing headers share the same 'trend' colour.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39626_master

      Description

      Formal_white give the admin some feature to customize the general aspect. In spite of this background images can not be changed. This means that the "brown" general colour is "almost" forced! It would be nice to have a way to change background images too.

        Gliffy Diagrams

        1. blueberry.jpg
          15 kB
        2. lemon.jpg
          15 kB
        3. lime.jpg
          15 kB
        4. mink.jpg
          14 kB
        5. orange.jpg
          15 kB
        6. peach.jpg
          15 kB
        7. silver.jpg
          14 kB
        8. tiny_issue1.png
          25 kB
        9. tiny_issue2.png
          12 kB

          Activity

          Hide
          lazydaisy Mary Evans added a comment - - edited

          Daniele, I have just changed the subject title for this tracker to reflect the changes that need to be made, plus changed the issue type from 'Bug' to 'Improvement'. And since this improvement cannot be back ported, you can use the new feature of adding the 'File Picker' to Formal White custom settings.
          Checkout Afterburner for the php code in settings.php, lib.php and db/upgrade.php.

          Cheers
          Mary

          Show
          lazydaisy Mary Evans added a comment - - edited Daniele, I have just changed the subject title for this tracker to reflect the changes that need to be made, plus changed the issue type from 'Bug' to 'Improvement'. And since this improvement cannot be back ported, you can use the new feature of adding the 'File Picker' to Formal White custom settings. Checkout Afterburner for the php code in settings.php, lib.php and db/upgrade.php. Cheers Mary
          Hide
          daniss Daniele Cordella added a comment -

          Choose formal_white as your theme.
          Go to formal_white settings page. Use the "Trend color" drop down menu to select a colour. Submit the theme settings page and look at a moodle page. Navigation bar, block headers and some more background images should change the colour according to your selection.

          Show
          daniss Daniele Cordella added a comment - Choose formal_white as your theme. Go to formal_white settings page. Use the "Trend color" drop down menu to select a colour. Submit the theme settings page and look at a moodle page. Navigation bar, block headers and some more background images should change the colour according to your selection.
          Hide
          daniss Daniele Cordella added a comment -

          Ciao Mary.
          The issue you are talking about is waiting for some answer in https://moodle.org/mod/forum/discuss.php?d=228238
          The solution is ready but I would have support from moodle HQ instead of looking for a silly workaround before submitting the patch. As said: the patch is ready and working. I am only waiting for an answer.

          Here I add a way to change colours to navbar, block headers and some more html tag taking colours from background images.
          Ciao.

          Show
          daniss Daniele Cordella added a comment - Ciao Mary. The issue you are talking about is waiting for some answer in https://moodle.org/mod/forum/discuss.php?d=228238 The solution is ready but I would have support from moodle HQ instead of looking for a silly workaround before submitting the patch. As said: the patch is ready and working. I am only waiting for an answer. Here I add a way to change colours to navbar, block headers and some more html tag taking colours from background images. Ciao.
          Hide
          lazydaisy Mary Evans added a comment -

          Just checkout this out for you Daniele. I will report back shortly.

          Show
          lazydaisy Mary Evans added a comment - Just checkout this out for you Daniele. I will report back shortly.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          Ciao Daniele,
          I like what you are trying to do but I don't like the way it looks. I feel that the images need to be softer/lighter, less saturation.

          I also feel that if you are looking to change the overall colour-scheme, I would like to see the frame/background change too.

          In the attached image I managed to get a 'total' makeover with a colour I called 'giallo' which is as you know 'yellow' in Italian.

          I have also attached the zip file of the associated 'trend/giallo' folder.

          If you would like me to convert the other trend images to make them lighter, less saturated, I would be happy to that.

          Hope this helps?

          Show
          lazydaisy Mary Evans added a comment - - edited Ciao Daniele, I like what you are trying to do but I don't like the way it looks. I feel that the images need to be softer/lighter, less saturation. I also feel that if you are looking to change the overall colour-scheme, I would like to see the frame/background change too. In the attached image I managed to get a 'total' makeover with a colour I called 'giallo' which is as you know 'yellow' in Italian. I have also attached the zip file of the associated 'trend/giallo' folder. If you would like me to convert the other trend images to make them lighter, less saturated, I would be happy to that. Hope this helps?
          Hide
          lazydaisy Mary Evans added a comment -

          Uploaded giallo.zip and screenshot

          Show
          lazydaisy Mary Evans added a comment - Uploaded giallo.zip and screenshot
          Hide
          daniss Daniele Cordella added a comment - - edited

          Yes, yes, yes. Mary sure!
          I am a disaster with images and software for picture management.
          Yes, please, do whatever you can with my bloody images. Change them as much as you like.
          Feel free to even add colours, if you like.
          The code I added will scan the theme/pix/trend folder so whatever you add will be added in the theme settings file. (For each colour you add you will be requested to add its name in theme/lang/en/formal_white.php file.)
          I want a working technical solution, images are a detail I do not see at all.
          Please, proceed!
          Thanks, thanks a lot.

          Show
          daniss Daniele Cordella added a comment - - edited Yes, yes, yes. Mary sure! I am a disaster with images and software for picture management. Yes, please, do whatever you can with my bloody images. Change them as much as you like. Feel free to even add colours, if you like. The code I added will scan the theme/pix/trend folder so whatever you add will be added in the theme settings file. (For each colour you add you will be requested to add its name in theme/lang/en/formal_white.php file.) I want a working technical solution, images are a detail I do not see at all. Please, proceed! Thanks, thanks a lot.
          Hide
          daniss Daniele Cordella added a comment -

          Add even more images (like borders if you like). I will adapt the code to follow your input. This issue will become a great improvement.
          Thanks again.

          Show
          daniss Daniele Cordella added a comment - Add even more images (like borders if you like). I will adapt the code to follow your input. This issue will become a great improvement. Thanks again.
          Hide
          lazydaisy Mary Evans added a comment -

          OK I will see what I can do.

          Show
          lazydaisy Mary Evans added a comment - OK I will see what I can do.
          Hide
          lazydaisy Mary Evans added a comment -

          That was fun!

          Show
          lazydaisy Mary Evans added a comment - That was fun!
          Hide
          lazydaisy Mary Evans added a comment -

          Just adding my branch so you can peer review my changes to the existing code it Daniele ( or Andrea).

          Show
          lazydaisy Mary Evans added a comment - Just adding my branch so you can peer review my changes to the existing code it Daniele ( or Andrea).
          Hide
          lazydaisy Mary Evans added a comment -

          Daniele, I have temporarily assigned this to me so that I could add you as Peer Reviewer.

          Show
          lazydaisy Mary Evans added a comment - Daniele, I have temporarily assigned this to me so that I could add you as Peer Reviewer.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          Just added Rick Jerz as a watcher as he is the 'numero uno' Formal White fan!
          And I am sure he will love testing this.

          Show
          lazydaisy Mary Evans added a comment - - edited Just added Rick Jerz as a watcher as he is the 'numero uno' Formal White fan! And I am sure he will love testing this.
          Hide
          daniss Daniele Cordella added a comment -

          I love and super love your contribution.
          Thanks a lot, Mary.
          I only found two tiny issues. They are described by the two new attachments (tiny_issue1 and 2).
          I already fixed the tiny_issue2 but I need your support to increase the size of gradient_h.png
          The rationale is this: up to yesterday I vertically extended the cover of the block header image using the background colour. Today the picture is no longer static so the background has to follow it. A way to follow it should be increasing the height of the picture. Do you agree?

          Show
          daniss Daniele Cordella added a comment - I love and super love your contribution. Thanks a lot, Mary. I only found two tiny issues. They are described by the two new attachments (tiny_issue1 and 2). I already fixed the tiny_issue2 but I need your support to increase the size of gradient_h.png The rationale is this: up to yesterday I vertically extended the cover of the block header image using the background colour. Today the picture is no longer static so the background has to follow it. A way to follow it should be increasing the height of the picture. Do you agree?
          Hide
          daniss Daniele Cordella added a comment -

          one more issue I found in you code is that you forget in curse.css
          .course_category_tree .category > .info {
          background-image:url([[pix:theme|hgradient]]);
          background-repeat:repeat-x;
          border:1px solid #ddd;
          }
          instead of:
          .course_category_tree .category > .info {
          background-image:url([[pix:theme|trend/__setting_trendcolor__/hgradient]]);
          background-repeat:repeat-x;
          border:1px solid #ddd;
          }

          Show
          daniss Daniele Cordella added a comment - one more issue I found in you code is that you forget in curse.css .course_category_tree .category > .info { background-image:url([ [pix:theme|hgradient] ]); background-repeat:repeat-x; border:1px solid #ddd; } instead of: .course_category_tree .category > .info { background-image:url([ [pix:theme|trend/__setting_trendcolor__/hgradient] ]); background-repeat:repeat-x; border:1px solid #ddd; }
          Hide
          daniss Daniele Cordella added a comment -

          Last point: I also enclosed roundcorner images in a specialized colour subfolder. I updated the code according to these new locations. On github (https://github.com/kordan/moodle/compare/master...MDL-39626_master) my last branch.
          Waiting for your news, Mary.
          Thanks again.

          Show
          daniss Daniele Cordella added a comment - Last point: I also enclosed roundcorner images in a specialized colour subfolder. I updated the code according to these new locations. On github ( https://github.com/kordan/moodle/compare/master...MDL-39626_master ) my last branch. Waiting for your news, Mary. Thanks again.
          Hide
          daniss Daniele Cordella added a comment -

          Mary, I thought a better solution for background colours. Do you know how to set the status of this issue back to "Development in progress"?
          I am preparing one more release and I will push it asap.

          Show
          daniss Daniele Cordella added a comment - Mary, I thought a better solution for background colours. Do you know how to set the status of this issue back to "Development in progress"? I am preparing one more release and I will push it asap.
          Hide
          daniss Daniele Cordella added a comment -

          I just submitted a solution that is starting to work as expected.
          Andrea, Rick... what do you think about?
          As of me, it is ready for peer review.
          I close my development here until something new comes out.
          Thanks again to Mary.

          Show
          daniss Daniele Cordella added a comment - I just submitted a solution that is starting to work as expected. Andrea, Rick... what do you think about? As of me, it is ready for peer review. I close my development here until something new comes out. Thanks again to Mary.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          Daniele,
          I did make the gradient_h 60px in height, for one (mink) but not all of the images. My fault. This means you don't need the extra setting for b/g/color as I think this is just making hard work for Moodle.

          I'll see what I can do later.

          Also...any corrections, like the typos you have corrected in general.php, report.php, etc., these should be done in a new tracker issue.

          We are also trying to clean up CSS so this will need to be done before 2.6.

          I think you might like to think about adding the rounded corners using CSS3 radius and box-shadow rather than images, which should make it easier to change b/ground color in modern browsers.

          Cheers
          Mary

          Show
          lazydaisy Mary Evans added a comment - - edited Daniele, I did make the gradient_h 60px in height, for one (mink) but not all of the images. My fault. This means you don't need the extra setting for b/g/color as I think this is just making hard work for Moodle. I'll see what I can do later. Also...any corrections, like the typos you have corrected in general.php, report.php, etc., these should be done in a new tracker issue. We are also trying to clean up CSS so this will need to be done before 2.6. I think you might like to think about adding the rounded corners using CSS3 radius and box-shadow rather than images, which should make it easier to change b/ground color in modern browsers. Cheers Mary
          Hide
          lazydaisy Mary Evans added a comment -

          I'll fix the images after lunch!

          Show
          lazydaisy Mary Evans added a comment - I'll fix the images after lunch!
          Hide
          daniss Daniele Cordella added a comment - - edited

          No, Mary! No. No need at all to fix images.
          I found a better solution for background colours.
          Sorry, I was sure I had written this... but I didn't.

          I already implemented the better solution and pushed it.
          Please, just download last patch release and spread out you opinion.

          > Also...any corrections, like the typos you have corrected in general.php,
          > report.php, etc., these should be done in a new tracker issue.
          I definitely do not think so. They belong to the development of this same issue.
          Integrator will say the last word!

          About CSS3... please help me. I have no knowledge of it.

          As usual and once again, thank you for your great a huge contribution.

          Show
          daniss Daniele Cordella added a comment - - edited No, Mary! No. No need at all to fix images. I found a better solution for background colours. Sorry, I was sure I had written this... but I didn't. I already implemented the better solution and pushed it. Please, just download last patch release and spread out you opinion. > Also...any corrections, like the typos you have corrected in general.php, > report.php, etc., these should be done in a new tracker issue. I definitely do not think so. They belong to the development of this same issue. Integrator will say the last word! About CSS3... please help me. I have no knowledge of it. As usual and once again, thank you for your great a huge contribution.
          Hide
          daniss Daniele Cordella added a comment -

          Ok, it is time to disclose my soul. I love grey and I hate brown... even if FW was born with brown dresses.
          May I ask you, please, a grey colour set to add it, quickly, to this patch before its peer review?
          Once you give me the set I will update and push the code. Which name? "Grey"? "Mouse"? "Alluminium"?
          As usual: thanks in advance.

          Show
          daniss Daniele Cordella added a comment - Ok, it is time to disclose my soul. I love grey and I hate brown... even if FW was born with brown dresses. May I ask you, please, a grey colour set to add it, quickly, to this patch before its peer review? Once you give me the set I will update and push the code. Which name? "Grey"? "Mouse"? "Alluminium"? As usual: thanks in advance.
          Hide
          lazydaisy Mary Evans added a comment -

          silver = grey = gray

          I will do this now.

          Show
          lazydaisy Mary Evans added a comment - silver = grey = gray I will do this now.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          Just noticed that the default is brown, I forgot to change the default to 'mink' which use the same image as the ones in the original brown folder which I renamed to mink.

          Show
          lazydaisy Mary Evans added a comment - - edited Just noticed that the default is brown, I forgot to change the default to 'mink' which use the same image as the ones in the original brown folder which I renamed to mink.
          Hide
          lazydaisy Mary Evans added a comment -

          I'm just testing the Silver color trend.

          Show
          lazydaisy Mary Evans added a comment - I'm just testing the Silver color trend.
          Hide
          lazydaisy Mary Evans added a comment -

          Adding the Silver screenshot

          Show
          lazydaisy Mary Evans added a comment - Adding the Silver screenshot
          Hide
          lazydaisy Mary Evans added a comment -

          OK...here are all my changes squashed into new branch.

          https://github.com/lazydaisy/moodle/compare/master...wip_MDL39626_master

          I was so in a hurry I missed out the dash in the tracker reference. LOL

          Show
          lazydaisy Mary Evans added a comment - OK...here are all my changes squashed into new branch. https://github.com/lazydaisy/moodle/compare/master...wip_MDL39626_master I was so in a hurry I missed out the dash in the tracker reference. LOL
          Hide
          daniss Daniele Cordella added a comment -

          Thanks Mary.
          Silver has already been added and pushed.
          Correct default too.
          I had an exciting week-end. Thanks Mary, thanks for all your commitment.
          Ciao.

          Show
          daniss Daniele Cordella added a comment - Thanks Mary. Silver has already been added and pushed. Correct default too. I had an exciting week-end. Thanks Mary, thanks for all your commitment. Ciao.
          Hide
          lazydaisy Mary Evans added a comment -

          Daniele, you did not grab the gradient_h.jpg images for the other trend colours. I made it 60px high so that the need for block colour is not needed. It is hardly likely that the headers will be deeper than that, if so then the text is too big.

          If you are happy it will stay like this then you need to – squash your commits into a new branch then commit/push and then submit for integration.

          Thanks
          Mary

          Show
          lazydaisy Mary Evans added a comment - Daniele, you did not grab the gradient_h.jpg images for the other trend colours. I made it 60px high so that the need for block colour is not needed. It is hardly likely that the headers will be deeper than that, if so then the text is too big. If you are happy it will stay like this then you need to – squash your commits into a new branch then commit/push and then submit for integration. Thanks Mary
          Hide
          daniss Daniele Cordella added a comment -

          > Daniele, you did not grab the gradient_h.jpg images for the other trend colours.
          Mary, the height of the block headers depends from a lot of variables: length of the text, font size, block column width... so I added a routine to fill the remaining block header with the "right" background colour. I no longer care about the height of the gradient_h.

          > squash your commits into a new branch then commit/push and then submit for integration
          Are you saying I have to compact my github branch in one single push?

          Show
          daniss Daniele Cordella added a comment - > Daniele, you did not grab the gradient_h.jpg images for the other trend colours. Mary, the height of the block headers depends from a lot of variables: length of the text, font size, block column width... so I added a routine to fill the remaining block header with the "right" background colour. I no longer care about the height of the gradient_h. > squash your commits into a new branch then commit/push and then submit for integration Are you saying I have to compact my github branch in one single push?
          Hide
          daniss Daniele Cordella added a comment -

          You are right, Mary.
          Now my github branch is only one push long.
          Thanks.

          Show
          daniss Daniele Cordella added a comment - You are right, Mary. Now my github branch is only one push long. Thanks.
          Hide
          andreabix Andrea Bicciolo added a comment -

          Thank you very much for those amazing improvements to the theme. I'm sure the straightforward customizations now possible using FW will be much appreciated by users.

          Show
          andreabix Andrea Bicciolo added a comment - Thank you very much for those amazing improvements to the theme. I'm sure the straightforward customizations now possible using FW will be much appreciated by users.
          Hide
          daniss Daniele Cordella added a comment -

          Mary, as you may imagine I am already using this patch and my local moodle looks really cool.
          As an outcome of this I have two background info and one more proposal.
          First background info: as you know on the basis of the chosen trend the theme assign a background colour to the page and to block headers. This background color is hardcoded and depends from the "trend".
          Second background info: this morning a lady looking at my "orange" formal_white page said: "cool, but gray background for block's columns is ugly!"
          My proposal: why don't we assign a "nice looking" default background color to:
          -> block's columns
          -> alternate colors for rows in the course page such as for row in tables,
          -> block content
          -> vertical dock
          as we already assigned a color to page background and block headers background?

          Once the color trend assigns this list of colours to their default, the user will always be allowed to change them "manually" through a direct access to their setting control.
          Your involvement: provide, as a refined lady, the list of "nice looking" colours
          My involvement: write the code

          What do you think about?

          Show
          daniss Daniele Cordella added a comment - Mary, as you may imagine I am already using this patch and my local moodle looks really cool. As an outcome of this I have two background info and one more proposal. First background info: as you know on the basis of the chosen trend the theme assign a background colour to the page and to block headers. This background color is hardcoded and depends from the "trend". Second background info: this morning a lady looking at my "orange" formal_white page said: "cool, but gray background for block's columns is ugly!" My proposal: why don't we assign a "nice looking" default background color to: -> block's columns -> alternate colors for rows in the course page such as for row in tables, -> block content -> vertical dock as we already assigned a color to page background and block headers background? Once the color trend assigns this list of colours to their default, the user will always be allowed to change them "manually" through a direct access to their setting control. Your involvement: provide, as a refined lady, the list of "nice looking" colours My involvement: write the code What do you think about?
          Hide
          lazydaisy Mary Evans added a comment - - edited

          Ciao Daniele,

          I've been away, so just reading your last comment now.

          What you are proposing sounds like a good idea. The best thing to go is create a META Tracker to develop Formal White so we can put all these new 'Trend Color' features together.

          Show
          lazydaisy Mary Evans added a comment - - edited Ciao Daniele, I've been away, so just reading your last comment now. What you are proposing sounds like a good idea. The best thing to go is create a META Tracker to develop Formal White so we can put all these new 'Trend Color' features together.
          Hide
          daniss Daniele Cordella added a comment -

          Is a meta tracker really needed?
          With the time, I will post a branch on my github with a working solution.
          I will ask you to fill my proof of concept with the missing colours, if you agree.

          Show
          daniss Daniele Cordella added a comment - Is a meta tracker really needed? With the time, I will post a branch on my github with a working solution. I will ask you to fill my proof of concept with the missing colours, if you agree.
          Hide
          lazydaisy Mary Evans added a comment -

          I just thought that a meta issue (improvements) would keep all this together that is all, as it is a new idea, and related. It is only for tidiness and reference.

          Show
          lazydaisy Mary Evans added a comment - I just thought that a meta issue (improvements) would keep all this together that is all, as it is a new idea, and related. It is only for tidiness and reference.
          Hide
          poltawski Dan Poltawski added a comment -

          This is an improvement and we are only accepting bugfixes to master at the present time, so i'm holding this issue until we start accepting new changes for 2.6

          Show
          poltawski Dan Poltawski added a comment - This is an improvement and we are only accepting bugfixes to master at the present time, so i'm holding this issue until we start accepting new changes for 2.6
          Hide
          daniss Daniele Cordella added a comment -

          @Dan: is there simething I can do in order to include this patch in m25 too?.

          Show
          daniss Daniele Cordella added a comment - @Dan: is there simething I can do in order to include this patch in m25 too?.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Daniele, this has been integrated now to master only.

          Regarding getting this changed backported you could create a request to backport it, however our policy is to only accept bug fixes to stable branches. As such you'd have to have a very good reason for us to backport it.
          You can read more about out backport policy here: http://docs.moodle.org/dev/Integration_Review#Backporting

          Many thanks
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Daniele, this has been integrated now to master only. Regarding getting this changed backported you could create a request to backport it, however our policy is to only accept bug fixes to stable branches. As such you'd have to have a very good reason for us to backport it. You can read more about out backport policy here: http://docs.moodle.org/dev/Integration_Review#Backporting Many thanks Sam
          Hide
          daniss Daniele Cordella added a comment -

          Thanks Sam for your explanation.
          May I ask for comment from you on MDL-39201. TIA

          Show
          daniss Daniele Cordella added a comment - Thanks Sam for your explanation. May I ask for comment from you on MDL-39201 . TIA
          Hide
          fred Frédéric Massart added a comment -

          Hi everyone, sorry but I am going to fail the test.

          1. The custom menu dropdown does not inherit the new style
          2. I find the colour of the links/texts in the breadcrumb a bit light on the coloured background
          3. The current course section could inherit the colour too (marked with the light bulb)
          4. The quiz questions are hardcoded to blue (when attempting a quiz)
          5. The sidebar containing the docked blocks is grey, could inherit too?
          6. The docked blocks title does not properly wordwrap and extend the background when the title is long (possible unrelated)
          7. The docked blocks edit icons (when editing is turned on) can appear above the title (unrelated)
          8. The notifications page does not inherit the colours

          Please ignore if not relevant, or not related!

          Cheers,
          Fred

          Show
          fred Frédéric Massart added a comment - Hi everyone, sorry but I am going to fail the test. The custom menu dropdown does not inherit the new style I find the colour of the links/texts in the breadcrumb a bit light on the coloured background The current course section could inherit the colour too (marked with the light bulb) The quiz questions are hardcoded to blue (when attempting a quiz) The sidebar containing the docked blocks is grey, could inherit too? The docked blocks title does not properly wordwrap and extend the background when the title is long (possible unrelated) The docked blocks edit icons (when editing is turned on) can appear above the title (unrelated) The notifications page does not inherit the colours Please ignore if not relevant, or not related! Cheers, Fred
          Hide
          daniss Daniele Cordella added a comment -

          Ciao Fred
          and thanks for your input.
          The elements you found missing like:
          -> the colour of the links/texts in the breadcrumb a bit light on the coloured background
          or
          -> the sidebar containing the docked blocks
          are in our heart. We plan to include them in the frame of MDL-39694.
          Please have a look at my comment, in this same page, of 14/mag/13 8:26 AM
          At this stage, we only broke the wall of "change of colours".
          That is all.

          Show
          daniss Daniele Cordella added a comment - Ciao Fred and thanks for your input. The elements you found missing like: -> the colour of the links/texts in the breadcrumb a bit light on the coloured background or -> the sidebar containing the docked blocks are in our heart. We plan to include them in the frame of MDL-39694 . Please have a look at my comment, in this same page, of 14/mag/13 8:26 AM At this stage, we only broke the wall of "change of colours". That is all.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi guys,

          To keep this moving I've created issues as required for the points Fred noted:

          1. MDL-40261
          2. MDL-40262
          3. MDL-40263
          4. Not sure about this one, Tim has hard coded it I suggest we just don't worry about.
          5. MDL-40263
          6. MDL-40265
          7. MDL-40265
          8. Not sure what you were expecting Fred. I looked at the notifications page and things looked fine, would you mind clarifying.

          Reopening this for testing now so that you both can have a look and we can move this issue forwards.

          Many thanks
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Hi guys, To keep this moving I've created issues as required for the points Fred noted: MDL-40261 MDL-40262 MDL-40263 Not sure about this one, Tim has hard coded it I suggest we just don't worry about. MDL-40263 MDL-40265 MDL-40265 Not sure what you were expecting Fred. I looked at the notifications page and things looked fine, would you mind clarifying. Reopening this for testing now so that you both can have a look and we can move this issue forwards. Many thanks Sam
          Hide
          fred Frédéric Massart added a comment -

          Thanks Sam, as you raised an issue for each of the points raised (and I raised MDL-40269 for the notifications page), I am passing this issue.

          Cheers,
          Fred

          Show
          fred Frédéric Massart added a comment - Thanks Sam, as you raised an issue for each of the points raised (and I raised MDL-40269 for the notifications page), I am passing this issue. Cheers, Fred
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks for your contributions!

          _main:
          @ BB#0:
                  push    {r7, lr}
                  mov     r7, sp
                  sub     sp, #4
                  movw    r0, :lower16:(L_.str-(LPC0_0+4))
                  movt    r0, :upper16:(L_.str-(LPC0_0+4))
          LPC0_0:
                  add     r0, pc
                  bl      _printf
                  movs    r1, #0
                  movt    r1, #0
                  str     r0, [sp]                @ 4-byte Spill
                  mov     r0, r1
                  add     sp, #4
                  pop     {r7, pc}
           
                  .section        __TEXT,__cstring,cstring_literals
          L_.str:                                 @ @.str
                  .asciz   "This code is now upstream!"
          

          Show
          poltawski Dan Poltawski added a comment - Thanks for your contributions! _main: @ BB#0: push {r7, lr} mov r7, sp sub sp, #4 movw r0, :lower16:(L_.str-(LPC0_0+4)) movt r0, :upper16:(L_.str-(LPC0_0+4)) LPC0_0: add r0, pc bl _printf movs r1, #0 movt r1, #0 str r0, [sp] @ 4-byte Spill mov r0, r1 add sp, #4 pop {r7, pc}   .section __TEXT,__cstring,cstring_literals L_.str: @ @.str .asciz "This code is now upstream!"

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13