Moodle
  1. Moodle
  2. MDL-39629

Enable formal_white to upload custom logo

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: Themes
    • Labels:

      Description

      Use admin_setting_configstoredfile to select custom logo in formal_white

        Gliffy Diagrams

          Activity

          Hide
          Daniele Cordella added a comment - - edited

          TAKE CARE: this patch requires a tiny change in setting_file_url in HEAD/lib/outputlib.php.
          I feel my request to change it is acceptable. Even though I explained my need and asked for support and suggestion in https://moodle.org/mod/forum/discuss.php?d=228238.

          Show
          Daniele Cordella added a comment - - edited TAKE CARE: this patch requires a tiny change in setting_file_url in HEAD/lib/outputlib.php. I feel my request to change it is acceptable. Even though I explained my need and asked for support and suggestion in https://moodle.org/mod/forum/discuss.php?d=228238 .
          Hide
          Petr Skoda added a comment -

          The core change is not necessary in my opinion, if really needed we should add support for protocol relative urls directly into moodle_url.

          Show
          Petr Skoda added a comment - The core change is not necessary in my opinion, if really needed we should add support for protocol relative urls directly into moodle_url.
          Hide
          Daniele Cordella added a comment -

          Thanks Petr,
          can you suggest a short solution to my need of complete URL as described in https://moodle.org/mod/forum/discuss.php?d=228238?

          Show
          Daniele Cordella added a comment - Thanks Petr, can you suggest a short solution to my need of complete URL as described in https://moodle.org/mod/forum/discuss.php?d=228238?
          Hide
          Petr Skoda added a comment -

          I do not see any problem there, just use the url without http.

          Show
          Petr Skoda added a comment - I do not see any problem there, just use the url without http.
          Hide
          Daniele Cordella added a comment -

          Cool! Thanks! You are 150% right, Petr. Thank you. I didn't get this simple solution.
          I change my git hub according to your suggestion!

          Show
          Daniele Cordella added a comment - Cool! Thanks! You are 150% right, Petr. Thank you. I didn't get this simple solution. I change my git hub according to your suggestion!
          Hide
          Daniele Cordella added a comment -

          Just updated my git hub, ready for peer review.
          Credits to Petr for the suggestion.

          Show
          Daniele Cordella added a comment - Just updated my git hub, ready for peer review. Credits to Petr for the suggestion.
          Hide
          Sam Hemelryk added a comment -

          Thanks Daniele this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Daniele this has been integrated now.
          Hide
          Sam Hemelryk added a comment -

          Please add testing instructions next time

          Show
          Sam Hemelryk added a comment - Please add testing instructions next time
          Hide
          Sam Hemelryk added a comment -

          Added missing theme_formal_white_pluginfile function (theme/formal_white/lib.php) after which everything works perfectly.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Added missing theme_formal_white_pluginfile function (theme/formal_white/lib.php) after which everything works perfectly. Many thanks Sam
          Hide
          Daniele Cordella added a comment - - edited

          Thanks Sam!
          I am happy to see this patch is supposed to land to 2.6 so, maybe, I will find the time to work on MDL-39694 too.

          Show
          Daniele Cordella added a comment - - edited Thanks Sam! I am happy to see this patch is supposed to land to 2.6 so, maybe, I will find the time to work on MDL-39694 too.
          Hide
          Marina Glancy added a comment -

          Thanks for your awesome work! This has now become a part of Moodle.

          Closing as fixed!

          Show
          Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: