Details

    • Rank:
      50339

      Description

      The current I expand the "" node step can be used to expand and to collapse tree nodes and it is used like that but the step name does not reflect that. After talking about it in the integration chat, we can create a new step I collapse the "" node

        Activity

        Hide
        Dan Poltawski added a comment -

        Hi David,

        Looks good to me. Only question is whether it would be worthwhile/possible to verify the 'expanded' state of the node to help with errors writing tests.

        Show
        Dan Poltawski added a comment - Hi David, Looks good to me. Only question is whether it would be worthwhile/possible to verify the 'expanded' state of the node to help with errors writing tests.
        Hide
        David Monllaó added a comment -

        Thanks Dan; yes, I'll do it, I'm trying to change the status of the issue to dev. in progress but I can't, please dear integrator, don't review the issue (I thought I would never say that) until next comment.

        Show
        David Monllaó added a comment - Thanks Dan; yes, I'll do it, I'm trying to change the status of the issue to dev. in progress but I can't, please dear integrator, don't review the issue (I thought I would never say that) until next comment.
        Hide
        David Monllaó added a comment -

        Patch updated, I've ran most of the features that includes expanding nodes

        Show
        David Monllaó added a comment - Patch updated, I've ran most of the features that includes expanding nodes
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (25 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (25 & master), thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Note that the testing "asdasd" branch was conflicting, not critical but better verify it in the future because the tester may not known how to behave.

        Anyway, once I fixed the conflicts... I got all them passing, so nice:

        12 escenarios (12 exitosos)
        237 pasos (237 exitosos)
        12m38.034s

        Passing...

        Show
        Eloy Lafuente (stronk7) added a comment - Note that the testing "asdasd" branch was conflicting, not critical but better verify it in the future because the tester may not known how to behave. Anyway, once I fixed the conflicts... I got all them passing, so nice: 12 escenarios (12 exitosos) 237 pasos (237 exitosos) 12m38.034s Passing...
        Hide
        David Monllaó added a comment -

        Oww sorry, I didn't knew what would be integrated, in future I'll point to a hash rather than pull a branch

        Show
        David Monllaó added a comment - Oww sorry, I didn't knew what would be integrated, in future I'll point to a hash rather than pull a branch
        Hide
        Damyon Wiese added a comment -

        Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone.

        Closing as Fixed!

        Show
        Damyon Wiese added a comment - Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone. Closing as Fixed!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: