Moodle
  1. Moodle
  2. MDL-39639

If the calendar is open and the date picker form element is disabled, the calendar does not close.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to Site administration ► Users ► Accounts ► Browse list of users
      2. Click "Show more"
      3. Enable First access (date field)
      4. Click on calender icon to open calendar
      5. Disable First access by clicking on checkbox
      6. make sure calendar is not visible.
      7. Repeat above steps and make sure behaviour is consistent.
      Show
      Go to Site administration ► Users ► Accounts ► Browse list of users Click "Show more" Enable First access (date field) Click on calender icon to open calendar Disable First access by clicking on checkbox make sure calendar is not visible. Repeat above steps and make sure behaviour is consistent.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-mdl-39639
    • Rank:
      50340

      Description

      If the calendar is open and the date picker form element is disabled, the calendar does not close.

        Issue Links

          Activity

          Hide
          Mark Nelson added a comment -

          Great job Rajey boy, you have done us all proud. Submitting to integration.

          Show
          Mark Nelson added a comment - Great job Rajey boy, you have done us all proud. Submitting to integration.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Hi Raj,

          Should this be cherry-picked to 2.5?

          Show
          Dan Poltawski added a comment - Hi Raj, Should this be cherry-picked to 2.5?
          Hide
          Mark Nelson added a comment -

          Hi Dan, yes it should.

          Show
          Mark Nelson added a comment - Hi Dan, yes it should.
          Hide
          Dan Poltawski added a comment -

          Integrated to master and 25 - thanks!

          Show
          Dan Poltawski added a comment - Integrated to master and 25 - thanks!
          Hide
          David Monllaó added a comment -

          All working as expected. Thanks

          Show
          David Monllaó added a comment - All working as expected. Thanks
          Hide
          Marina Glancy added a comment -

          Thanks for your awesome work! This has now become a part of Moodle.

          Closing as fixed!

          Show
          Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: