Moodle
  1. Moodle
  2. MDL-39640

Undefined property when userwatermarks is not set (editing only)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.3.8, 2.4.5, 2.5.1
    • Component/s: Repositories
    • Labels:
      None
    • Rank:
      50341

      Description

      When editing / updating a Flickr public repository, if Add watermark to photos is left unchecked you get the following notice:

      Notice: Undefined property: stdClass::$usewatermarks in /home/adrian/moodles/stable_master_postgres/moodle/repository/manage_instances.php on line 182 
      

        Issue Links

          Activity

          Hide
          Frédéric Massart added a comment -

          This is blocked by MDL-38369. I used isset or null, because it's what's used on the admin settings page.

          Show
          Frédéric Massart added a comment - This is blocked by MDL-38369 . I used isset or null, because it's what's used on the admin settings page.
          Hide
          Rajesh Taneja added a comment -

          Thanks Fred,

          Patch looks good, pushing for integration as MDL-38369 is integrated.

          Show
          Rajesh Taneja added a comment - Thanks Fred, Patch looks good, pushing for integration as MDL-38369 is integrated.
          Hide
          Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Damyon Wiese added a comment -

          Thanks Fred,

          The change looks spot on and it has been integrated to 23, 24, 25 and master.

          Show
          Damyon Wiese added a comment - Thanks Fred, The change looks spot on and it has been integrated to 23, 24, 25 and master.
          Hide
          Adrian Greeve added a comment -

          Tested on 2.3, 2.4 and master integration branches.
          No undefined property came up when the user watermark was not set.
          I noticed that in 2.3 and 2.4 that the repository name needed to be changed every time that I was editing, but this is to be resolved in: MDL-39667.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on 2.3, 2.4 and master integration branches. No undefined property came up when the user watermark was not set. I noticed that in 2.3 and 2.4 that the repository name needed to be changed every time that I was editing, but this is to be resolved in: MDL-39667 . Test passed.
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers!

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers! Regards, Damyon

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: