Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3, 2.4.4, 2.5, 2.5.1
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      PREREQUSITE: your moodle configured to send email.

      1. Download the attached IMS enterprise enrolment file and put it in your moodledata directory
      2. Go to Home / Site administration / Plugins / Enrolments
      3. Enable the IMS enterprise enrolment plugin
      4. In the settings, provide the path to the file you uploaded in File location
      5. Tick Notify admin by email
      6. Save settings
      7. Go to the link 'perform an IMS Enterprise import right now'
      8. VERIFY: the IMS enrolment works ok
      9. VERIFY: no debugging is experienced
      10. VERIFY: you receive a message about the enrollment by email
      11. Go to the link 'perform an IMS Enterprise import right now'
      12. VERIFY: the IMS enrollment is skipped because the file hasn't changed
      13. VERIFY: no debugging is experienced
      14. Rename the ims enrollment file
      15. Go to the link 'perform an IMS Enterprise import right now'
      16. VERIFY: the IMS enrollment is skipped because the file isn't there
      17. VERIFY: no debugging is experienced
      18. VERIFY: no message about the enrolment is received.
      Show
      PREREQUSITE: your moodle configured to send email. Download the attached IMS enterprise enrolment file and put it in your moodledata directory Go to Home / Site administration / Plugins / Enrolments Enable the IMS enterprise enrolment plugin In the settings, provide the path to the file you uploaded in File location Tick Notify admin by email Save settings Go to the link 'perform an IMS Enterprise import right now' VERIFY: the IMS enrolment works ok VERIFY: no debugging is experienced VERIFY: you receive a message about the enrollment by email Go to the link 'perform an IMS Enterprise import right now' VERIFY: the IMS enrollment is skipped because the file hasn't changed VERIFY: no debugging is experienced Rename the ims enrollment file Go to the link 'perform an IMS Enterprise import right now' VERIFY: the IMS enrollment is skipped because the file isn't there VERIFY: no debugging is experienced VERIFY: no message about the enrolment is received.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39653-master
    • Story Points (Obsolete):
      2
    • Sprint:
      BACKEND Sprint 5

      Description

      Moodle 2.4.3

      Line 220 of /enrol/imsenterprise/lib.php

      This IF block should NOT run if the file does not exists or if the file is not new. When the file does not exist or is not new, an error is thrown at line 220 because $timeelapsed is not set. This causes the entire Moodle cron job to fail.

      Suggest either moving that block within the IF block above, or changing to:

      if (!empty($mailadmins) && file_exists($filename) && $fileisnew) {

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Nov/13