Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39667

Updating a repository instance configuration requires a change of instance name (Backport of MDL-39641)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.7, 2.4.4
    • Fix Version/s: 2.3.8, 2.4.5
    • Component/s: Repositories
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Enable Flickr Public
      2. Create a system instance
      3. Make sure you can create/edit the instance
      4. Make sure you can edit the options, without changing the name
      5. Repeat for User and Course instances
      Show
      Enable Flickr Public Create a system instance Make sure you can create/edit the instance Make sure you can edit the options, without changing the name Repeat for User and Course instances
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:

      Description

      MDL-39641 was only integrated to master because it arrived too late to go into the stable releases. This issue is just to backport the fix to 24 and 23.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              fred Frédéric Massart added a comment - - edited

              Submit for integration as it passed peer review in MDL-39641. Erg, no it didn't...

              Show
              fred Frédéric Massart added a comment - - edited Submit for integration as it passed peer review in MDL-39641 . Erg, no it didn't...
              Hide
              schach Heiko Schach added a comment -

              In the release notes this is described as known bug fixed in the next weekly release.
              http://docs.moodle.org/dev/Moodle_2.4.4_release_notes#Known_Bugs
              http://docs.moodle.org/dev/Moodle_2.3.7_release_notes#Known_Bugs

              The original issue MDL-39641 was classified as major.
              Still the backport hasn't landed yet in 2.3.7 and 2.4.4.
              Can you please fix this? Thank you.

              Show
              schach Heiko Schach added a comment - In the release notes this is described as known bug fixed in the next weekly release. http://docs.moodle.org/dev/Moodle_2.4.4_release_notes#Known_Bugs http://docs.moodle.org/dev/Moodle_2.3.7_release_notes#Known_Bugs The original issue MDL-39641 was classified as major. Still the backport hasn't landed yet in 2.3.7 and 2.4.4. Can you please fix this? Thank you.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks for fixing this Fred,

              Patch looks spot-on, pushing it for integration review.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Fred, Patch looks spot-on, pushing it for integration review.
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated to 24 and 23 - thanks Fred!

              Show
              poltawski Dan Poltawski added a comment - Integrated to 24 and 23 - thanks Fred!
              Hide
              dmonllao David Monllaó added a comment -

              It passes, tested in 23 and 24

              Show
              dmonllao David Monllaó added a comment - It passes, tested in 23 and 24
              Hide
              marina Marina Glancy added a comment -

              Thanks for your awesome work! This has now become a part of Moodle.

              Closing as fixed!

              Show
              marina Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    8/Jul/13