Moodle
  1. Moodle
  2. MDL-39667

Updating a repository instance configuration requires a change of instance name (Backport of MDL-39641)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.7, 2.4.4
    • Fix Version/s: 2.3.8, 2.4.5
    • Component/s: Repositories
    • Labels:
      None
    • Rank:
      50390

      Description

      MDL-39641 was only integrated to master because it arrived too late to go into the stable releases. This issue is just to backport the fix to 24 and 23.

        Issue Links

          Activity

          Hide
          Frédéric Massart added a comment - - edited

          Submit for integration as it passed peer review in MDL-39641. Erg, no it didn't...

          Show
          Frédéric Massart added a comment - - edited Submit for integration as it passed peer review in MDL-39641 . Erg, no it didn't...
          Hide
          Heiko Schach added a comment -

          In the release notes this is described as known bug fixed in the next weekly release.
          http://docs.moodle.org/dev/Moodle_2.4.4_release_notes#Known_Bugs
          http://docs.moodle.org/dev/Moodle_2.3.7_release_notes#Known_Bugs

          The original issue MDL-39641 was classified as major.
          Still the backport hasn't landed yet in 2.3.7 and 2.4.4.
          Can you please fix this? Thank you.

          Show
          Heiko Schach added a comment - In the release notes this is described as known bug fixed in the next weekly release. http://docs.moodle.org/dev/Moodle_2.4.4_release_notes#Known_Bugs http://docs.moodle.org/dev/Moodle_2.3.7_release_notes#Known_Bugs The original issue MDL-39641 was classified as major. Still the backport hasn't landed yet in 2.3.7 and 2.4.4. Can you please fix this? Thank you.
          Hide
          Rajesh Taneja added a comment -

          Thanks for fixing this Fred,

          Patch looks spot-on, pushing it for integration review.

          Show
          Rajesh Taneja added a comment - Thanks for fixing this Fred, Patch looks spot-on, pushing it for integration review.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Integrated to 24 and 23 - thanks Fred!

          Show
          Dan Poltawski added a comment - Integrated to 24 and 23 - thanks Fred!
          Hide
          David Monllaó added a comment -

          It passes, tested in 23 and 24

          Show
          David Monllaó added a comment - It passes, tested in 23 and 24
          Hide
          Marina Glancy added a comment -

          Thanks for your awesome work! This has now become a part of Moodle.

          Closing as fixed!

          Show
          Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: