Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39673

Backport MDL-38441 (stylesheet system problems with large sheets in IE)

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.4.4
    • 2.4.5
    • Themes
    • MOODLE_24_STABLE
    • MOODLE_24_STABLE
    • Hide

      To test in best faith you could follow through:
      Run the unit tests.
      Log in as an admin, ensure theme designer mode is off and then purge your caches.
      Using Firefox/Chrome/Safari browse around the site and check things look as expected. Repeat for a couple of themes including standard, and clean.
      Switch to IE browse around the site and check things look as expected. Repeat for the same themes as above.

      Open lib/csslib.php in an editor.
      Search for the use of css_chunk_by_selector_count within css_store_css and make its third arg 1500.
      Save the change.
      Using IE log in as an admin and purge your caches.
      Inspect the CSS loaded once the redirecting is finished.
      Check that the style sheets that the import statements within the first three CSS sheets contain either "/_s/" or "svg=0"

      Show
      To test in best faith you could follow through: Run the unit tests. Log in as an admin, ensure theme designer mode is off and then purge your caches. Using Firefox/Chrome/Safari browse around the site and check things look as expected. Repeat for a couple of themes including standard, and clean. Switch to IE browse around the site and check things look as expected. Repeat for the same themes as above. Open lib/csslib.php in an editor. Search for the use of css_chunk_by_selector_count within css_store_css and make its third arg 1500. Save the change. Using IE log in as an admin and purge your caches. Inspect the CSS loaded once the redirecting is finished. Check that the style sheets that the import statements within the first three CSS sheets contain either "/_s/" or "svg=0"

    Description

      MDL-38441 was applied for Moodle 2.5+ only although it also affects 2.4, which is still supported.

      In 2.4, the problem does not affect standard core but if you have a lot of plugins, the plugins CSS file can exceed the 4095 selector limit.

      The change backports cleanly.

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38441 Style sheet system creates files with > 4095 selectors

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Activity

            People

              quen Sam Marshall
              quen Sam Marshall
              Damyon Wiese Damyon Wiese
              David Monllaó David Monllaó
              Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                8/Jul/13