Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39673

Backport MDL-38441 (stylesheet system problems with large sheets in IE)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.4
    • Fix Version/s: 2.4.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      To test in best faith you could follow through:
      Run the unit tests.
      Log in as an admin, ensure theme designer mode is off and then purge your caches.
      Using Firefox/Chrome/Safari browse around the site and check things look as expected. Repeat for a couple of themes including standard, and clean.
      Switch to IE browse around the site and check things look as expected. Repeat for the same themes as above.

      Open lib/csslib.php in an editor.
      Search for the use of css_chunk_by_selector_count within css_store_css and make its third arg 1500.
      Save the change.
      Using IE log in as an admin and purge your caches.
      Inspect the CSS loaded once the redirecting is finished.
      Check that the style sheets that the import statements within the first three CSS sheets contain either "/_s/" or "svg=0"

      Show
      To test in best faith you could follow through: Run the unit tests. Log in as an admin, ensure theme designer mode is off and then purge your caches. Using Firefox/Chrome/Safari browse around the site and check things look as expected. Repeat for a couple of themes including standard, and clean. Switch to IE browse around the site and check things look as expected. Repeat for the same themes as above. Open lib/csslib.php in an editor. Search for the use of css_chunk_by_selector_count within css_store_css and make its third arg 1500. Save the change. Using IE log in as an admin and purge your caches. Inspect the CSS loaded once the redirecting is finished. Check that the style sheets that the import statements within the first three CSS sheets contain either "/_s/" or "svg=0"
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE

      Description

      MDL-38441 was applied for Moodle 2.5+ only although it also affects 2.4, which is still supported.

      In 2.4, the problem does not affect standard core but if you have a lot of plugins, the plugins CSS file can exceed the 4095 selector limit.

      The change backports cleanly.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    8/Jul/13