Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Clean theme
      2. If not already enabled, go to Development > Debugging and enable debugging, validators, page info, performance info.
      3. On saving and Purging all caches TEST that the debugging info (performance info, validators, purgecaches, etc...) in the footer is all centre aligned.
      Show
      Select Clean theme If not already enabled, go to Development > Debugging and enable debugging, validators, page info, performance info. On saving and Purging all caches TEST that the debugging info (performance info, validators, purgecaches, etc...) in the footer is all centre aligned.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39680_master

      Description

      The alignment is a bit out of whack in Clean. See screenshot.

        Gliffy Diagrams

          Activity

          Hide
          andyjdavis Andrew Davis added a comment -

          In Standard all that stuff is centred.

          Show
          andyjdavis Andrew Davis added a comment - In Standard all that stuff is centred.
          Hide
          lazydaisy Mary Evans added a comment -

          I did wonder why this was all to the left when in Standard was centered. I just assumed it was a preference for the Bootstrap theme.

          I'll change this and get it fixed in next pull.
          Thanks for reporting this Andrew.

          Show
          lazydaisy Mary Evans added a comment - I did wonder why this was all to the left when in Standard was centered. I just assumed it was a preference for the Bootstrap theme. I'll change this and get it fixed in next pull. Thanks for reporting this Andrew.
          Hide
          damyon Damyon Wiese added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          damyon Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          damyon Damyon Wiese added a comment -

          Thanks Mary, it looks much better now.

          Integrated to 25 and master.

          Show
          damyon Damyon Wiese added a comment - Thanks Mary, it looks much better now. Integrated to 25 and master.
          Hide
          barbararamiro Barbara Ramiro added a comment - - edited

          Tested on master and passed

          Show
          barbararamiro Barbara Ramiro added a comment - - edited Tested on master and passed
          Hide
          lazydaisy Mary Evans added a comment -

          Cool thanks Barbara!

          Show
          lazydaisy Mary Evans added a comment - Cool thanks Barbara!
          Hide
          barbararamiro Barbara Ramiro added a comment -

          Thanks too Mary =)

          Show
          barbararamiro Barbara Ramiro added a comment - Thanks too Mary =)
          Hide
          damyon Damyon Wiese added a comment -

          Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers!

          Regards, Damyon

          Show
          damyon Damyon Wiese added a comment - Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers! Regards, Damyon

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/13