The phrase "Message" next to the text box has been pushed onto a separate line.

The text box isnt centred.

The send message button isnt centred.

Messages are meant to be listed under the user that sent them. That appears to be a bit out of whack.

This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

Hi,

Sorry, i'm afraid i've played with this and I don't see how this change is fixing anything? I can't spot it.

Also reading the testing instructions, it looks to me like its working as per the testing instructions beforehand?

I've attached screenshots of before/after the patch - and I just can't see the change.

Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

I'm sending this for peer review, as Dan I had troubles understanding what Nadav's patch was doing. In fact, without the patch the messages are aligned with the wrong user... the messages from User A appear underneath the ones of User B. I picked the patch in my branches and pushed it. Thanks Nadav.

I added a commit because I noticed that this was already an issue on Standard.

Hi Nadav and Fred,

Thank you for working on this. As Fred mentioned above, after applying the patch, I could only distinguished the different on the message alignment.

Some additional note, the UI for this page could be improved by clarifying which message is written by which user (currently, it indicates by timestamps).

Other than that, the patch looks great.

Hi Rosie,

I am not sure to understand what you mean with the timestamps. Could you illustrate with a screenshot please?

Many thanks!
Fred

Hi Fred,

I attached a screenshot for the message page.

Instead of using the user's name as indication, it used time (eg: 3:24 am) as the label.

Oh I understand what you mean, thanks for clarifying. Surely this interface is a bit outdated now, but I'm afraid that this is out of the scope of this issue. You are right though, this could be highly improved, and benefit from proper responsive design. Pushing this for integration.

Thanks Nadav and Fred. Integrated to 25, 26 and master. Appears to work correctly for me.

Thanks Fred - tested and passed

I won't be saying "Thanks!" this week. I'm tired of it.

For the good (and the bad), your code is now part of Moodle, the best LMS in the world. Hope you are contributing for that to continue being a fact (and not the opposite), sincerely.

Just closing this as fixed, ciao

PS: Just a bit of black/cruel humor, sorry, LOL!