Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38856 META: Issues around Bootstrapbase and Clean theme
  3. MDL-39697

Bootstrapbase $THEME->layouts need 'Maintenance' and is missing important options.

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.5
    • 2.5.1
    • Themes
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • Hide
      1. Select Clean theme
      2. Add a new plugin or something to trigger the Maintenance layout or put site in Maintenance Mode.
      3. TEST that the layout looks part of the Clean theme layout.
      4. TEST that there are NO blocks present in the layout.
      5. TEST that there are NO links in the footer.
      Show
      Select Clean theme Add a new plugin or something to trigger the Maintenance layout or put site in Maintenance Mode. TEST that the layout looks part of the Clean theme layout. TEST that there are NO blocks present in the layout. TEST that there are NO links in the footer.

    Description

      After a chance comment by phalacee in MDL-39573, and on inspection of bootstrapbase/config.php, later revealed that the maintenance layout was incorrect and missing important options namely:

       'maintenance' => array(
              'file' => 'general.php',
              'regions' => array(),
              'options' => array('noblocks' => true, 'nofooter' => true, 'nonavbar' => true, 'nocustommenu' => true, 'nocourseheaderfooter' => true),
          ),
      

      Also comparing it with base theme showed up other settings to.

      That said, the intention of this issue is to add Base $THEME->layouts so that some continuity is maintained for future versions of Moodle.

      Attachments

        Issue Links

          Activity

            People

              lazydaisy Mary Evans
              lazydaisy Mary Evans
              Damyon Wiese Damyon Wiese
              Adrian Greeve Adrian Greeve
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                8/Jul/13