Moodle
  1. Moodle
  2. MDL-3971

brackets not inside the span in the edited message

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Forum
    • Labels:
      None
    • Environment:
      All
    • Rank:
      6788

      Description

      When a message was modified, a message ( edited by name - date ) is added.

      In the html code, brackets are not inside the span

      I think that it would be better if the brackets were inside the span. No ?

      So in mod/forum/lib.php, the line 2291

      $post->message .= '<p>(<span class=edited>'.$editedby.'</span>)</p>';

      would be :

      $post->message .= '<p><span class=edited>('.$editedby.')</span></p>';

        Activity

        Hide
        Martin Dougiamas added a comment -

        Assigning to me temporarily because Vy-Shane no longer works for Moodle HQ.

        Show
        Martin Dougiamas added a comment - Assigning to me temporarily because Vy-Shane no longer works for Moodle HQ.
        Hide
        Dan Poltawski added a comment -

        Well I checked the CSS and the only place usign this is mymboile theme to reduce the size of the edit.

        So I thought it was time for us to get rid of this v.old issue

        Show
        Dan Poltawski added a comment - Well I checked the CSS and the only place usign this is mymboile theme to reduce the size of the edit. So I thought it was time for us to get rid of this v.old issue
        Hide
        Sam Hemelryk added a comment -

        Thanks Dan, looks like this may be the oldest issue to be fixed in 2.3!
        Has been integrated to master and cherry-picked to 21 and 22.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks Dan, looks like this may be the oldest issue to be fixed in 2.3! Has been integrated to master and cherry-picked to 21 and 22. Cheers Sam
        Hide
        Adrian Greeve added a comment -

        Tested in 2.1, 2.2, and master. The brackets are now inside the span.
        No problems.
        Thanks

        Show
        Adrian Greeve added a comment - Tested in 2.1, 2.2, and master. The brackets are now inside the span. No problems. Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

        Many, many thanks for your hard work!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: