Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: 2.0
-
Component/s: Forum
-
Labels:None
-
Environment:All
-
Testing Instructions:
- As student create a new forum post
- As admin edit said forum post
- View edited result examine the html the brackets should be within the span
-
Affected Branches:MOODLE_20_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
When a message was modified, a message ( edited by name - date ) is added.
In the html code, brackets are not inside the span
I think that it would be better if the brackets were inside the span. No ?
So in mod/forum/lib.php, the line 2291
$post->message .= '<p>(<span class=edited>'.$editedby.'</span>)</p>';
would be :
$post->message .= '<p><span class=edited>('.$editedby.')</span></p>';
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Well I checked the CSS and the only place usign this is mymboile theme to reduce the size of the edit.
So I thought it was time for us to get rid of this v.old issue 
Thanks Dan, looks like this may be the oldest issue to be fixed in 2.3!
Has been integrated to master and cherry-picked to 21 and 22.
Cheers
Sam
Tested in 2.1, 2.2, and master. The brackets are now inside the span.
No problems.
Thanks 
And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!
Many, many thanks for your hard work!
Ciao 
Assigning to me temporarily because Vy-Shane no longer works for Moodle HQ.