Moodle
  1. Moodle
  2. MDL-39710

Rubric can't be hidden from students

    Details

    • Testing Instructions:
      Hide
      1. Login as a teacher with capability 'moodle/grade:managegradingforms'
      2. Create assignment with grading method Rubric
      3. Create rubric, check option "show definition to students" (default checked)
      4. Login as a student and make sure you can see the definition (both on assignment page and link in navigation menu)
      5. Login as a teacher and uncheck option "show definition to students"
      6. Login as a student and make sure you can NOT see the definition (both on assignment page and link in navigation menu)
      7. Add capability 'moodle/grade:sharegradingforms' to teacher
      8. Login as a teacher, view rubric, publish it as a template
      9. Create another assignment graded as rubric, make sure you can pick the rubric from template and the definition is diplayed (checking for regressions)

      Repeat the test for Marking guide

      Show
      Login as a teacher with capability 'moodle/grade:managegradingforms' Create assignment with grading method Rubric Create rubric, check option "show definition to students" (default checked) Login as a student and make sure you can see the definition (both on assignment page and link in navigation menu) Login as a teacher and uncheck option "show definition to students" Login as a student and make sure you can NOT see the definition (both on assignment page and link in navigation menu) Add capability 'moodle/grade:sharegradingforms' to teacher Login as a teacher, view rubric, publish it as a template Create another assignment graded as rubric, make sure you can pick the rubric from template and the definition is diplayed (checking for regressions) Repeat the test for Marking guide
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull 2.4 Branch:
      wip-MDL-39710-m24
    • Pull 2.5 Branch:
      wip-MDL-39710-m25
    • Pull Master Branch:
      wip-MDL-39710-master
    • Rank:
      50445

      Description

      • Add an assignment and use the advanced grading option Grade > Grading method > Rubric.
      • Save & Display
      • Define new Grading form from scratch
      • Create a basic Rubric by editing "click to edit level/criterion" etc
      • Untick all rubric options including "Allow users to preview rubric used in the module (otherwise rubric will only become visible after grading)".
      • Choose "Save Rubric and make it ready"
      • Login as a student and note that the Rubric is still visible even though it shouldn't be.
      • Note: Ticking and unticking the Rubric options doesn't appear to be making any difference, are they supposed to? Are these options connected to anything and should they work?

        Issue Links

          Activity

          Hide
          Marina Glancy added a comment -

          I could reproduce it. The menu item "Submission grading" (Added by rubrics plugin) is added only if checkbox is checked. But mod_assign displays the rubric always regardless of the setting.

          This setting is specific for rubrics only and is checked in gradingform_rubric_controller::extend_navigation()
          Maybe it makes sense to add it also to gradingform_rubric_controller::render_preview()

          (Sorry Damyon, I accidentally assigned it to you instead of adding you as a watcher)

          Show
          Marina Glancy added a comment - I could reproduce it. The menu item "Submission grading" (Added by rubrics plugin) is added only if checkbox is checked. But mod_assign displays the rubric always regardless of the setting. This setting is specific for rubrics only and is checked in gradingform_rubric_controller::extend_navigation() Maybe it makes sense to add it also to gradingform_rubric_controller::render_preview() (Sorry Damyon, I accidentally assigned it to you instead of adding you as a watcher)
          Hide
          Russell Boyatt added a comment -

          As you suggest this seems to require a small change to gradingform_rubric_controller::render_preview() and I've created a branch to fix. Here is the diff against master if somebody could give this a try...

          https://github.com/rboyatt/moodle/compare/master...MDL-39710-rubric-visible-to-students

          Show
          Russell Boyatt added a comment - As you suggest this seems to require a small change to gradingform_rubric_controller::render_preview() and I've created a branch to fix. Here is the diff against master if somebody could give this a try... https://github.com/rboyatt/moodle/compare/master...MDL-39710-rubric-visible-to-students
          Hide
          Marina Glancy added a comment - - edited

          Hi Russell,
          yes-yes, that's right. I added commit on top of yours that makes sure that description is also not displayed and copied it to marking guide.

          Dan Marsden, please take a look at the fix too

          Show
          Marina Glancy added a comment - - edited Hi Russell, yes-yes, that's right. I added commit on top of yours that makes sure that description is also not displayed and copied it to marking guide. Dan Marsden , please take a look at the fix too
          Hide
          Marina Glancy added a comment -

          PS confirmed with Damyon that mod_assign started inline display of advanced grading methods only in 2.4 so there is no need to backport this to 2.3

          Show
          Marina Glancy added a comment - PS confirmed with Damyon that mod_assign started inline display of advanced grading methods only in 2.4 so there is no need to backport this to 2.3
          Hide
          Russell Boyatt added a comment -

          Marina - great, thanks for looking at that and adding the extra changes. Much appreciated.

          Show
          Russell Boyatt added a comment - Marina - great, thanks for looking at that and adding the extra changes. Much appreciated.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (24, 25 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (24, 25 & master), thanks!
          Hide
          Petr Škoda added a comment -

          Works fine, thanks.

          Show
          Petr Škoda added a comment - Works fine, thanks.
          Hide
          Dan Marsden added a comment -

          sorry for late response - long weekend but the work didn't stop coming in! - still catching up....

          patch makes sense to me! - thanks Marina.

          Show
          Dan Marsden added a comment - sorry for late response - long weekend but the work didn't stop coming in! - still catching up.... patch makes sense to me! - thanks Marina.
          Hide
          Dan Poltawski added a comment -
          Feature: Thanks to our superb contributors
            In order to make Moodle better
            As an integrator
            I need to thank all our contributors
          
            Scenario: Dan thanks you all
              Given I log in as "dan"
              And I see "lots of fixed issues"
              When I follow "Close integrated issues"
              Then I should see "Lots of thanks to all our contributors"
          

          Your changes are upstream

          Show
          Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream
          Hide
          David Monllaó added a comment -

          Hi,

          Working on MDL-42404 I was adding an automated test for this issue as it is labelled as acceptance_test_required. Please, can you check if the last commit is correct, for what I understand it is; the problem is that the student still sees the grades and the rubric description, in case the scenario is correct this issue is still failing (at least in master).

          Show
          David Monllaó added a comment - Hi, Working on MDL-42404 I was adding an automated test for this issue as it is labelled as acceptance_test_required. Please, can you check if the last commit is correct, for what I understand it is; the problem is that the student still sees the grades and the rubric description, in case the scenario is correct this issue is still failing (at least in master).
          Hide
          Marina Glancy added a comment -

          Hi David, of course student can see the grades in rubric. The issue was that sometimes teacher chooses to hide the rubric from student BEFORE he is graded. I'm pretty sure both description and testing instructions for this issue are quite clear.

          Also, rubric has a rubric description (only one, on top of the rubric), which sometimes can be an instruction for teachers, and it can be hidden from STUDENTS ("those being graded")

          The criteria descriptons are of course visible to students always, otherwise there is no point in using rubric at all. The points for each criterion can be optionally hidden

          Show
          Marina Glancy added a comment - Hi David, of course student can see the grades in rubric. The issue was that sometimes teacher chooses to hide the rubric from student BEFORE he is graded. I'm pretty sure both description and testing instructions for this issue are quite clear. Also, rubric has a rubric description (only one, on top of the rubric), which sometimes can be an instruction for teachers, and it can be hidden from STUDENTS ("those being graded") The criteria descriptons are of course visible to students always, otherwise there is no point in using rubric at all. The points for each criterion can be optionally hidden
          Hide
          David Monllaó added a comment -

          Thanks Marina, I was only doubting whether the criteria should be seen from the assignment or not; the testing instructions refers to the option "show definition to students" which does not exist, without specifying anything else. After reading your comment in https://tracker.moodle.org/browse/MDL-42404?focusedCommentId=269745&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-269745 I see that the option which controls that is Allow users to preview rubric used in the module (otherwise rubric will only become visible after grading) all working as expected and passing now.

          Show
          David Monllaó added a comment - Thanks Marina, I was only doubting whether the criteria should be seen from the assignment or not; the testing instructions refers to the option "show definition to students" which does not exist, without specifying anything else. After reading your comment in https://tracker.moodle.org/browse/MDL-42404?focusedCommentId=269745&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-269745 I see that the option which controls that is Allow users to preview rubric used in the module (otherwise rubric will only become visible after grading) all working as expected and passing now.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: