Moodle
  1. Moodle
  2. MDL-39717

JS dialogs and drag & drop are not stable enough to consider them valid steps

    Details

    • Testing Instructions:
      Hide

      Test 1

      1. git pull git://github.com/dmonllao/moodle.git MDL-39717_master-testme
      2. Run behat with --tags @MDL-39717
      3. They SHOULD all pass

      Test 2

      1. Go to site administration -> development -> acceptance testing
      2. Check the description of the following steps definitions list:
        • I move "" activity to section ""
        • I delete "" activity
        • I accept the currently displayed dialog
        • I drag "" "" and I drop it in "" ""
      3. They SHOULD all include a statement about it's experimentality
      Show
      Test 1 git pull git://github.com/dmonllao/moodle.git MDL-39717 _master-testme Run behat with --tags @ MDL-39717 They SHOULD all pass Test 2 Go to site administration -> development -> acceptance testing Check the description of the following steps definitions list: I move "" activity to section "" I delete "" activity I accept the currently displayed dialog I drag "" "" and I drop it in "" "" They SHOULD all include a statement about it's experimentality
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull 2.5 Branch:
    • Pull Master Branch:
      MDL-39717_master
    • Rank:
      50454

      Description

      Native JS modal dialogs and drag & drop support is not stable in all OS&browser combinations, we have MDL-39272 to improve drag & drop support but we will depend on selenium driver improvements to manage properly JS modal dialogs in all OS/browsers combinations.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          I'm commenting on this issue to test that David gets the message.

          Show
          Michael de Raadt added a comment - I'm commenting on this issue to test that David gets the message.
          Hide
          Michael de Raadt added a comment -

          I've unassigned this and adding another message.

          Show
          Michael de Raadt added a comment - I've unassigned this and adding another message.
          Hide
          Rajesh Taneja added a comment -

          Thanks David,

          Patch looks good, pushing for integration.

          Show
          Rajesh Taneja added a comment - Thanks David, Patch looks good, pushing for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (25 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (25 & master), thanks!
          Hide
          Michael de Raadt added a comment -

          I'm adding a note to say that I intend to test this issue, but I'm also taking it as an opportunity to establish a new testing environment, so it might take a bit of time.

          Show
          Michael de Raadt added a comment - I'm adding a note to say that I intend to test this issue, but I'm also taking it as an opportunity to establish a new testing environment, so it might take a bit of time.
          Hide
          Michael de Raadt added a comment -

          Test results under Windows...

          D:\xampp\htdocs\master_integration_behat>vendor\bin\behat --config D:\xampp\Data
          \master_integration_behat_behat\behat\behat.yml --format progress --tags @MDL-39
          717
          ...................................................................... 70
          ...................................................................... 140
          ...................................................................... 210
          ...................................................................... 280
          ...................................................................... 350
          ...................................................................... 420
          ...................................................................... 490
          ...................................................................... 560
          ...................................................................... 630
          ........................................................
          
          18 scenarios (18 passed)
          686 steps (686 passed)
          27m53.278s
          
          D:\xampp\htdocs\master_integration_behat>
          

          Linux results to come...

          Show
          Michael de Raadt added a comment - Test results under Windows... D:\xampp\htdocs\master_integration_behat>vendor\bin\behat --config D:\xampp\Data \master_integration_behat_behat\behat\behat.yml --format progress --tags @MDL-39 717 ...................................................................... 70 ...................................................................... 140 ...................................................................... 210 ...................................................................... 280 ...................................................................... 350 ...................................................................... 420 ...................................................................... 490 ...................................................................... 560 ...................................................................... 630 ........................................................ 18 scenarios (18 passed) 686 steps (686 passed) 27m53.278s D:\xampp\htdocs\master_integration_behat> Linux results to come...
          Hide
          Michael de Raadt added a comment -

          I just realised I started the Behat process without the specific tag set. I've restarted the testing with the flag (perhaps I should have let it continue), but I won't be here to see it end today.

          I will report the results first thing tomorrow morning.

          Testing continues...

          Show
          Michael de Raadt added a comment - I just realised I started the Behat process without the specific tag set. I've restarted the testing with the flag (perhaps I should have let it continue), but I won't be here to see it end today. I will report the results first thing tomorrow morning. Testing continues...
          Hide
          Michael de Raadt added a comment -

          Here are the Linux results...

          michael@salvetore-desktop:~/web/htdocs/master_integration_behat$ vendor/bin/behat --config /home/michael/web/data/master_integration_behat_behat:80/behat/behat.yml --tags @MDL-39717
          ...................................................................... 70
          ...................................................................... 140
          ...................................................................... 210
          ...................................................................... 280
          ...................................................................... 350
          ...................................................................... 420
          ...................................................................... 490
          ...................................................................... 560
          ...................................................................... 630
          ........................................................
          
          18 scenarios (18 passed)
          686 steps (686 passed)
          38m49.563s
          
          Show
          Michael de Raadt added a comment - Here are the Linux results... michael@salvetore-desktop:~/web/htdocs/master_integration_behat$ vendor/bin/behat --config /home/michael/web/data/master_integration_behat_behat:80/behat/behat.yml --tags @MDL-39717 ...................................................................... 70 ...................................................................... 140 ...................................................................... 210 ...................................................................... 280 ...................................................................... 350 ...................................................................... 420 ...................................................................... 490 ...................................................................... 560 ...................................................................... 630 ........................................................ 18 scenarios (18 passed) 686 steps (686 passed) 38m49.563s
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Show
          Michael de Raadt added a comment - Test result: Success!
          Hide
          Damyon Wiese added a comment -

          Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone.

          Closing as Fixed!

          Show
          Damyon Wiese added a comment - Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone. Closing as Fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: