Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39761

mod_assign: submission plugin status and visibility is not always checked

    Details

    • Testing Instructions:
      Hide

      Make sure that file and online text submissions (when user submit assignment) work as expected in the cases:

      1. User does not require to press submit button (in assignment settings)
      2. User require to press submit button (in assignment settings)
      Show
      Make sure that file and online text submissions (when user submit assignment) work as expected in the cases: User does not require to press submit button (in assignment settings) User require to press submit button (in assignment settings)
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39761-master

      Description

      We need to ensure that submission plugin is visible and enabled.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            damyon Damyon Wiese added a comment -

            Thanks Ruslan,

            This fix looks correct to me, thanks for the patch. I have raised the priority as I can see this causing bad things to happen in contrib plugins.

            Sending to integration now.

            Show
            damyon Damyon Wiese added a comment - Thanks Ruslan, This fix looks correct to me, thanks for the patch. I have raised the priority as I can see this causing bad things to happen in contrib plugins. Sending to integration now.
            Hide
            samhemelryk Sam Hemelryk added a comment - - edited

            Thanks Ruslan + Damyon, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - - edited Thanks Ruslan + Damyon, this has been integrated now.
            Hide
            phalacee Jason Fowler added a comment -

            Thanks Ruslan, works as described.

            Show
            phalacee Jason Fowler added a comment - Thanks Ruslan, works as described.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks for your contributions!

            _main:
            @ BB#0:
                    push    {r7, lr}
                    mov     r7, sp
                    sub     sp, #4
                    movw    r0, :lower16:(L_.str-(LPC0_0+4))
                    movt    r0, :upper16:(L_.str-(LPC0_0+4))
            LPC0_0:
                    add     r0, pc
                    bl      _printf
                    movs    r1, #0
                    movt    r1, #0
                    str     r0, [sp]                @ 4-byte Spill
                    mov     r0, r1
                    add     sp, #4
                    pop     {r7, pc}
             
                    .section        __TEXT,__cstring,cstring_literals
            L_.str:                                 @ @.str
                    .asciz   "This code is now upstream!"
            

            Show
            poltawski Dan Poltawski added a comment - Thanks for your contributions! _main: @ BB#0: push {r7, lr} mov r7, sp sub sp, #4 movw r0, :lower16:(L_.str-(LPC0_0+4)) movt r0, :upper16:(L_.str-(LPC0_0+4)) LPC0_0: add r0, pc bl _printf movs r1, #0 movt r1, #0 str r0, [sp] @ 4-byte Spill mov r0, r1 add sp, #4 pop {r7, pc}   .section __TEXT,__cstring,cstring_literals L_.str: @ @.str .asciz "This code is now upstream!"

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/13