Moodle
  1. Moodle
  2. MDL-39761

mod_assign: submission plugin status and visibility is not always checked

    Details

    • Rank:
      50501

      Description

      We need to ensure that submission plugin is visible and enabled.

        Activity

        Hide
        Damyon Wiese added a comment -

        Thanks Ruslan,

        This fix looks correct to me, thanks for the patch. I have raised the priority as I can see this causing bad things to happen in contrib plugins.

        Sending to integration now.

        Show
        Damyon Wiese added a comment - Thanks Ruslan, This fix looks correct to me, thanks for the patch. I have raised the priority as I can see this causing bad things to happen in contrib plugins. Sending to integration now.
        Hide
        Sam Hemelryk added a comment - - edited

        Thanks Ruslan + Damyon, this has been integrated now.

        Show
        Sam Hemelryk added a comment - - edited Thanks Ruslan + Damyon, this has been integrated now.
        Hide
        Jason Fowler added a comment -

        Thanks Ruslan, works as described.

        Show
        Jason Fowler added a comment - Thanks Ruslan, works as described.
        Hide
        Dan Poltawski added a comment -

        Thanks for your contributions!

        _main:
        @ BB#0:
                push    {r7, lr}
                mov     r7, sp
                sub     sp, #4
                movw    r0, :lower16:(L_.str-(LPC0_0+4))
                movt    r0, :upper16:(L_.str-(LPC0_0+4))
        LPC0_0:
                add     r0, pc
                bl      _printf
                movs    r1, #0
                movt    r1, #0
                str     r0, [sp]                @ 4-byte Spill
                mov     r0, r1
                add     sp, #4
                pop     {r7, pc}
        
                .section        __TEXT,__cstring,cstring_literals
        L_.str:                                 @ @.str
                .asciz   "This code is now upstream!"
        
        Show
        Dan Poltawski added a comment - Thanks for your contributions! _main: @ BB#0: push {r7, lr} mov r7, sp sub sp, #4 movw r0, :lower16:(L_.str-(LPC0_0+4)) movt r0, :upper16:(L_.str-(LPC0_0+4)) LPC0_0: add r0, pc bl _printf movs r1, #0 movt r1, #0 str r0, [sp] @ 4- byte Spill mov r0, r1 add sp, #4 pop {r7, pc} .section __TEXT,__cstring,cstring_literals L_.str: @ @.str .asciz "This code is now upstream!"

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: