Hi Rossiani Wijaya,

I wonder whether this is the same issue that Mark reported, but I can't quite tell from the description. It may well be a JS issue rather than blocks. Can you read that issue and see what you think?

Cheers,

Andrew

It would seem this is unrelated. This has to do with the formautosubmit javascript not triggering on touch devices.

Hi Jason,

I think that the solution that you have provided looks good, I'm just curious as to why you have added an extra line in:

• lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 124
• lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 123
• lib/yui/src/formautosubmit/js/formautosubmit.js line 121

Thanks.

I didn't add that line, my editor doesn't like no-blank lines on the last page of files. Will remove it manually, and repush. Thanks Adrian.

For the master fix, after this weeks integration, you can change it to:

if (Y.UA.touchenabled) {

}

Can only be on master as the touch + mouse enabled device issues would break this for older versions of YUI.

MDL-41208 is the issue this is blocked by

sure, will do that as soon as the other issue is integrated.

done now, will test it again later then push it.

Fixed and working, pushing for integration now

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Should this be fixed in 2.4?

Yes, the 2.5 patch should cherry-pick back to 2.4 cleanly.

It doesn't.

Reopening.

okay, will look at that ASAP.

Ah, the change in file paths for shifter, forgot about that. Added the patch for 2.4 now.

Integrated to master, 25 and 24 - thanks Jason

Tested on:

• Android Chrome
• Android Stock
• iOS 7.0
• Chrome (linux) without touch emulation
• Chrome (linux) with touch emulation
• Safari (Mac)

Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels.

Or, if you prefer, yes, you fixed that boring issue.

Thanks anyway! Ciao