Moodle
  1. Moodle
  2. MDL-39776

Adding new block doesn't automatically add the block to the page.

    Details

    • Testing Instructions:
      Hide

      Using any theme (Easiest using clean), Chrome and Stock browsers on Android AND iOS

      1. Log in as admin
      2. Add a block to a course
      3. Ensure it doesn't require multiple taps or clicks to add the block.
      Show
      Using any theme (Easiest using clean), Chrome and Stock browsers on Android AND iOS Log in as admin Add a block to a course Ensure it doesn't require multiple taps or clicks to add the block.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39776-master
    • Story Points (Obsolete):
      13
    • Sprint:
      FRONTEND Sprint 5

      Description

      Samsung tab II: Chrome and Stock browsers.

      On frontpage: adding new block doesn't automatically add the block to the page. It requires tapping the select option box to initiate the process.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Andrew Nicols added a comment -

            Hi Rossiani Wijaya,

            I wonder whether this is the same issue that Mark reported, but I can't quite tell from the description. It may well be a JS issue rather than blocks. Can you read that issue and see what you think?

            Cheers,

            Andrew

            Show
            Andrew Nicols added a comment - Hi Rossiani Wijaya , I wonder whether this is the same issue that Mark reported, but I can't quite tell from the description. It may well be a JS issue rather than blocks. Can you read that issue and see what you think? Cheers, Andrew
            Hide
            Jason Fowler added a comment -

            It would seem this is unrelated. This has to do with the formautosubmit javascript not triggering on touch devices.

            Show
            Jason Fowler added a comment - It would seem this is unrelated. This has to do with the formautosubmit javascript not triggering on touch devices.
            Hide
            Adrian Greeve added a comment -

            Hi Jason,

            I think that the solution that you have provided looks good, I'm just curious as to why you have added an extra line in:

            • lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 124
            • lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 123
            • lib/yui/src/formautosubmit/js/formautosubmit.js line 121

            Thanks.

            Show
            Adrian Greeve added a comment - Hi Jason, I think that the solution that you have provided looks good, I'm just curious as to why you have added an extra line in: lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 124 lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 123 lib/yui/src/formautosubmit/js/formautosubmit.js line 121 Thanks.
            Hide
            Jason Fowler added a comment -

            I didn't add that line, my editor doesn't like no-blank lines on the last page of files. Will remove it manually, and repush. Thanks Adrian.

            Show
            Jason Fowler added a comment - I didn't add that line, my editor doesn't like no-blank lines on the last page of files. Will remove it manually, and repush. Thanks Adrian.
            Hide
            Andrew Nicols added a comment -

            For the master fix, after this weeks integration, you can change it to:

            if (Y.UA.touchenabled) {
            }
            

            Can only be on master as the touch + mouse enabled device issues would break this for older versions of YUI.

            Show
            Andrew Nicols added a comment - For the master fix, after this weeks integration, you can change it to: if (Y.UA.touchenabled) { } Can only be on master as the touch + mouse enabled device issues would break this for older versions of YUI.
            Hide
            Andrew Nicols added a comment -

            MDL-41208 is the issue this is blocked by

            Show
            Andrew Nicols added a comment - MDL-41208 is the issue this is blocked by
            Hide
            Jason Fowler added a comment -

            sure, will do that as soon as the other issue is integrated.

            Show
            Jason Fowler added a comment - sure, will do that as soon as the other issue is integrated.
            Hide
            Jason Fowler added a comment -

            done now, will test it again later then push it.

            Show
            Jason Fowler added a comment - done now, will test it again later then push it.
            Hide
            Jason Fowler added a comment -

            Fixed and working, pushing for integration now

            Show
            Jason Fowler added a comment - Fixed and working, pushing for integration now
            Hide
            Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Should this be fixed in 2.4?

            Show
            Dan Poltawski added a comment - Should this be fixed in 2.4?
            Hide
            Jason Fowler added a comment -

            Yes, the 2.5 patch should cherry-pick back to 2.4 cleanly.

            Show
            Jason Fowler added a comment - Yes, the 2.5 patch should cherry-pick back to 2.4 cleanly.
            Hide
            Dan Poltawski added a comment -

            It doesn't.

            Reopening.

            Show
            Dan Poltawski added a comment - It doesn't. Reopening.
            Hide
            Jason Fowler added a comment -

            okay, will look at that ASAP.

            Show
            Jason Fowler added a comment - okay, will look at that ASAP.
            Hide
            Jason Fowler added a comment -

            Ah, the change in file paths for shifter, forgot about that. Added the patch for 2.4 now.

            Show
            Jason Fowler added a comment - Ah, the change in file paths for shifter, forgot about that. Added the patch for 2.4 now.
            Hide
            Dan Poltawski added a comment -

            Integrated to master, 25 and 24 - thanks Jason

            Show
            Dan Poltawski added a comment - Integrated to master, 25 and 24 - thanks Jason
            Hide
            Andrew Nicols added a comment -

            Tested on:

            • Android Chrome
            • Android Stock
            • iOS 7.0
            • Chrome (linux) without touch emulation
            • Chrome (linux) with touch emulation
            • Safari (Mac)
            Show
            Andrew Nicols added a comment - Tested on: Android Chrome Android Stock iOS 7.0 Chrome (linux) without touch emulation Chrome (linux) with touch emulation Safari (Mac)
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels.

            Or, if you prefer, yes, you fixed that boring issue.

            Thanks anyway! Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels. Or, if you prefer, yes, you fixed that boring issue. Thanks anyway! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Agile