Moodle

Adding new block doesn't automatically add the block to the page.

Details

Description

Samsung tab II: Chrome and Stock browsers.

On frontpage: adding new block doesn't automatically add the block to the page. It requires tapping the select option box to initiate the process.

Issue Links

duplicates

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40470 url_select triggers on click not on change.

  • Critical - Crashes server, loss of data, severe memory leak
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
will help resolve

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39816 "Add a resource" seems erratic on mobiles

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Nicols added a comment -

Hi Rossiani Wijaya,

I wonder whether this is the same issue that Mark reported, but I can't quite tell from the description. It may well be a JS issue rather than blocks. Can you read that issue and see what you think?

Cheers,

Andrew

Show
Andrew Nicols added a comment - Hi Rossiani Wijaya , I wonder whether this is the same issue that Mark reported, but I can't quite tell from the description. It may well be a JS issue rather than blocks. Can you read that issue and see what you think? Cheers, Andrew
Hide
Permalink
Jason Fowler added a comment -

It would seem this is unrelated. This has to do with the formautosubmit javascript not triggering on touch devices.

Show
Jason Fowler added a comment - It would seem this is unrelated. This has to do with the formautosubmit javascript not triggering on touch devices.
Hide
Permalink
Adrian Greeve added a comment -

Hi Jason,

I think that the solution that you have provided looks good, I'm just curious as to why you have added an extra line in:

  • lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 124
  • lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 123
  • lib/yui/src/formautosubmit/js/formautosubmit.js line 121

Thanks.

Show
Adrian Greeve added a comment - Hi Jason, I think that the solution that you have provided looks good, I'm just curious as to why you have added an extra line in: lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 124 lib/yui/build/moodle-core-formatautosubmit/moodle-core-formautosubmit.js line 123 lib/yui/src/formautosubmit/js/formautosubmit.js line 121 Thanks.
Hide
Permalink
Jason Fowler added a comment -

I didn't add that line, my editor doesn't like no-blank lines on the last page of files. Will remove it manually, and repush. Thanks Adrian.

Show
Jason Fowler added a comment - I didn't add that line, my editor doesn't like no-blank lines on the last page of files. Will remove it manually, and repush. Thanks Adrian.
Hide
Permalink
Andrew Nicols added a comment -

For the master fix, after this weeks integration, you can change it to:

if (Y.UA.touchenabled) {
}

Can only be on master as the touch + mouse enabled device issues would break this for older versions of YUI.

Show
Andrew Nicols added a comment - For the master fix, after this weeks integration, you can change it to: if (Y.UA.touchenabled) { } Can only be on master as the touch + mouse enabled device issues would break this for older versions of YUI.
Hide
Permalink
Andrew Nicols added a comment -

MDL-41208 is the issue this is blocked by

Show
Andrew Nicols added a comment - MDL-41208 is the issue this is blocked by
Hide
Permalink
Jason Fowler added a comment -

sure, will do that as soon as the other issue is integrated.

Show
Jason Fowler added a comment - sure, will do that as soon as the other issue is integrated.
Hide
Permalink
Jason Fowler added a comment -

done now, will test it again later then push it.

Show
Jason Fowler added a comment - done now, will test it again later then push it.
Hide
Permalink
Jason Fowler added a comment -

Fixed and working, pushing for integration now

Show
Jason Fowler added a comment - Fixed and working, pushing for integration now
Hide
Permalink
Dan Poltawski added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Dan Poltawski added a comment -

Should this be fixed in 2.4?

Show
Dan Poltawski added a comment - Should this be fixed in 2.4?
Hide
Permalink
Jason Fowler added a comment -

Yes, the 2.5 patch should cherry-pick back to 2.4 cleanly.

Show
Jason Fowler added a comment - Yes, the 2.5 patch should cherry-pick back to 2.4 cleanly.
Hide
Permalink
Dan Poltawski added a comment -

It doesn't.

Reopening.

Show
Dan Poltawski added a comment - It doesn't. Reopening.
Hide
Permalink
Jason Fowler added a comment -

okay, will look at that ASAP.

Show
Jason Fowler added a comment - okay, will look at that ASAP.
Hide
Permalink
Jason Fowler added a comment -

Ah, the change in file paths for shifter, forgot about that. Added the patch for 2.4 now.

Show
Jason Fowler added a comment - Ah, the change in file paths for shifter, forgot about that. Added the patch for 2.4 now.
Hide
Permalink
Dan Poltawski added a comment -

Integrated to master, 25 and 24 - thanks Jason

Show
Dan Poltawski added a comment - Integrated to master, 25 and 24 - thanks Jason
Hide
Permalink
Andrew Nicols added a comment -

Tested on:

  • Android Chrome
  • Android Stock
  • iOS 7.0
  • Chrome (linux) without touch emulation
  • Chrome (linux) with touch emulation
  • Safari (Mac)
Show
Andrew Nicols added a comment - Tested on: Android Chrome Android Stock iOS 7.0 Chrome (linux) without touch emulation Chrome (linux) with touch emulation Safari (Mac)
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels.

Or, if you prefer, yes, you fixed that boring issue.

Thanks anyway! Ciao

Show
Eloy Lafuente (stronk7) added a comment - Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels. Or, if you prefer, yes, you fixed that boring issue. Thanks anyway! Ciao

People

Vote (0)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved:

Agile