Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39777

Remove custom layouts from the clean theme.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable Debugging.
      2. Select Clean theme and TEST that it works without errors.
      3. Add a logo, Custom CSS and Footnote in Clean custom setting page.
      4. Change theme to Bootstrapbase and TEST that it works without errors.
      Show
      Enable Debugging. Select Clean theme and TEST that it works without errors. Add a logo, Custom CSS and Footnote in Clean custom setting page. Change theme to Bootstrapbase and TEST that it works without errors.
    • Affected Branches:
      MOODLE_25_STABLE

      Description

      If the bootstrapbase theme provided a way for a subtheme to add content to the header and footer, then there would be no need to have custom layouts in the clean theme.

      Having duplicated layouts is a headache for maintenance. Also themes that copy the clean theme will also copy the layouts and so when we add fixes to bootstrapbase, any inheriting theme will not get the fixes.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: