Moodle
  1. Moodle
  2. MDL-39795

Unresponsive script alerts kills test suite runs

    Details

    • Rank:
      50539

      Description

      When the Selenium response to a command takes a while the browser becomes unresponsive, if it is unresponsive for too much time it appears a beautiful JS dialog.

      Looking into the problem, the commands that takes more time are the ones that are asking for the whole page contents to look for texts, in fact the step I should see "whatever" is currently (based on the behat framework default behaviour) getting all page's contents (through //html xpath) and from there getting it's text() to find if it matches the "whatever" text with a regex. We must improve this, not only to solve the blocker issue, also to improve performance when possible.

      Important to run the whole suite features also using saucelabs to ensure all continues working as expected as these changes will affect most of the .feature files.

        Issue Links

          Activity

          Hide
          David Monllaó added a comment -

          Updating priority to Major as is currently breaking the test suite

          Show
          David Monllaó added a comment - Updating priority to Major as is currently breaking the test suite
          Hide
          David Monllaó added a comment - - edited

          After running the whole suite with this patch integrated, passing the 100% of the test + performance improvement + no more unresponsive script when using saucelabs

          Show
          David Monllaó added a comment - - edited After running the whole suite with this patch integrated, passing the 100% of the test + performance improvement + no more unresponsive script when using saucelabs
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (25 & master), thanks!

          Should that tiny double space be reported as a trivial issue perhaps? FYC.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (25 & master), thanks! Should that tiny double space be reported as a trivial issue perhaps? FYC.
          Hide
          Michael de Raadt added a comment -

          Starting testing. This will take ~5 hours.

          Show
          Michael de Raadt added a comment - Starting testing. This will take ~5 hours.
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          177 scenarios (177 passed)
          3573 steps (3573 passed)
          279m50.349s
          
          Show
          Michael de Raadt added a comment - Test result: Success! 177 scenarios (177 passed) 3573 steps (3573 passed) 279m50.349s
          Hide
          Damyon Wiese added a comment -

          Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers!

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers! Regards, Damyon
          Hide
          David Monllaó added a comment -

          Thanks Eloy, I've created MDL-40109

          Show
          David Monllaó added a comment - Thanks Eloy, I've created MDL-40109

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: