Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Select 'Standard' theme.
      3. Navigate to Home page.
      4. Navigate to Administration > Front page settings > reports > course participation.
      5. Take a screen shot.
      6. Change to 'Clean' theme.
      7. Navigate to Home page.
      8. Navigate to Administration > Front page settings > reports > course participation.
      9. Compare with 'screen shot' and note similarity.
      Show
      Log in as admin Select 'Standard' theme. Navigate to Home page. Navigate to Administration > Front page settings > reports > course participation. Take a screen shot. Change to 'Clean' theme. Navigate to Home page. Navigate to Administration > Front page settings > reports > course participation. Compare with 'screen shot' and note similarity.
    • Workaround:
      Hide

      None.

      Show
      None.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull 2.5 Branch:
      wip-MDL-39798_M25
    • Pull Master Branch:
      wip-MDL-39798_master
    • Rank:
      50541

      Description

      1. Log in as admin
      2. Select 'Clean' theme.
      3. Navigate to Home page.
      4. Navigate to Administration > Front page settings > reports > course participation.

      Improve alignment/layout for the page.

        Activity

        Hide
        Gareth J Barnard added a comment -

        Hi,

        Using FireBug / FireLess on this it appears that there is a difference between the Standard theme (based on base) and the Clean theme (based on Bootstrap base). The former has effectively 'inline' for the display setting and the latter 'block' which is causing the issue. But in '/report/participation/styles.css' there is:

        #page-report-participation-index .participationselectform label {
            margin-left: 15px;
            margin-right: 5px;
        }
        

        Which works fine with 'inline' but not with 'block' so what should happen? There is a debate about this: http://docs.moodle.org/dev/User:Damyon_Wiese/Draft_CSS_Framework.

        Currently, I propose only fixing 'Bootstrap base' to be inline and consistent with 'Base' on this and therefore 'inline' until the above is sorted.

        Cheers,

        Gareth

        Show
        Gareth J Barnard added a comment - Hi, Using FireBug / FireLess on this it appears that there is a difference between the Standard theme (based on base) and the Clean theme (based on Bootstrap base). The former has effectively 'inline' for the display setting and the latter 'block' which is causing the issue. But in '/report/participation/styles.css' there is: #page-report-participation-index .participationselectform label { margin-left: 15px; margin-right: 5px; } Which works fine with 'inline' but not with 'block' so what should happen? There is a debate about this: http://docs.moodle.org/dev/User:Damyon_Wiese/Draft_CSS_Framework . Currently, I propose only fixing 'Bootstrap base' to be inline and consistent with 'Base' on this and therefore 'inline' until the above is sorted. Cheers, Gareth
        Hide
        Mary Evans added a comment -

        What do you mean by:

        ...until the above is sorted.

        Show
        Mary Evans added a comment - What do you mean by: ...until the above is sorted.
        Hide
        Mary Evans added a comment -

        Gareth, I would not have even attempted to patch this as it is meant for FRONTEND teams to fix.

        Show
        Mary Evans added a comment - Gareth, I would not have even attempted to patch this as it is meant for FRONTEND teams to fix.
        Hide
        Mary Evans added a comment - - edited

        Hi Gareth, it would have been equally correct to have written this like so...

        #page-report-participation-index .participationselectform div label { // Using 'div' here to override the report styles.css
            display: inline;
            margin: 0 5px 0 0; // Adds right margin only for default LTR. 
        }
        #page-report-participation-index.dir-rtl .participationselectform div label {
            margin: 0 0 0 5px; // Adds left margin only for RTL.
        }
        
        Show
        Mary Evans added a comment - - edited Hi Gareth, it would have been equally correct to have written this like so... #page-report-participation-index .participationselectform div label { // Using 'div' here to override the report styles.css display: inline; margin: 0 5px 0 0; // Adds right margin only for default LTR. } #page-report-participation-index.dir-rtl .participationselectform div label { margin: 0 0 0 5px; // Adds left margin only for RTL. }
        Hide
        Mary Evans added a comment -

        Looks OK so submitting for Integration Review.

        Show
        Mary Evans added a comment - Looks OK so submitting for Integration Review.
        Hide
        Gareth J Barnard added a comment - - edited

        Dear Mary Evans,

        Thank you for peer reviewing this and putting for integration

        To answer your questions:

        'until above is sorted' refers to the debate about css in modules etc. that is being discussed on Damyon's CSS proposal - http://docs.moodle.org/dev/User:Damyon_Wiese/Draft_CSS_Framework - which may in future make this patch redundant in the simplification of css, but in the mean time this makes it really obvious what has been done and why.

        Your solution loses the intent of having left and right margins for the elements in the list bar the first for which I wanted as flush as possible against the block area

        I took on this patch on the basis that it was unassigned given the new rules - http://docs.moodle.org/dev/Changes_to_issue_assignment - which state 'If an issue already has an assignee, other developers may be reluctant to volunteer to take on an issue. We want to encourage developers to be involved in resolving issues without impediments.'. Of course if it was already assigned I would not go near the issue bar to make helpful comments.

        Thanks again,

        Gareth

        Show
        Gareth J Barnard added a comment - - edited Dear Mary Evans , Thank you for peer reviewing this and putting for integration To answer your questions: 'until above is sorted' refers to the debate about css in modules etc. that is being discussed on Damyon's CSS proposal - http://docs.moodle.org/dev/User:Damyon_Wiese/Draft_CSS_Framework - which may in future make this patch redundant in the simplification of css, but in the mean time this makes it really obvious what has been done and why. Your solution loses the intent of having left and right margins for the elements in the list bar the first for which I wanted as flush as possible against the block area I took on this patch on the basis that it was unassigned given the new rules - http://docs.moodle.org/dev/Changes_to_issue_assignment - which state 'If an issue already has an assignee, other developers may be reluctant to volunteer to take on an issue. We want to encourage developers to be involved in resolving issues without impediments.'. Of course if it was already assigned I would not go near the issue bar to make helpful comments. Thanks again, Gareth
        Hide
        Mary Evans added a comment -

        Ah..I see what you mean. Good thinking Batman!

        Show
        Mary Evans added a comment - Ah..I see what you mean. Good thinking Batman!
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
        Hide
        Mark Nelson added a comment -

        Works as expected, the form appears on one line when using the clean theme. Thanks for your efforts working on this!

        Show
        Mark Nelson added a comment - Works as expected, the form appears on one line when using the clean theme. Thanks for your efforts working on this!
        Hide
        Marina Glancy added a comment -

        Thanks for your awesome work! This has now become a part of Moodle.

        Closing as fixed!

        Show
        Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: