Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-3980

rss block noise in db error log

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: None
    • Component/s: Blocks
    • Labels:
      None
    • Environment:
      All
    • Database:
      PostgreSQL
    • Affected Branches:
      MOODLE_15_STABLE

      Description

      Error: invalid input syntax for integer: none

      Query: SELECT * FROM nmit_block_rss_client WHERE id = 'none' LIMIT 1

      this seems to be from block_rss_client_action.php and a combination of

      $rssid = optional_param('rssid', 'none' );

      and

      $rss_record = get_record('block_rss_client', 'id', $rssid);

      I would change default to 0 but not sure of the implication. There doesn't seem to be a validation of $rss_record being set anywhere, but it's used all throughout this file.

      (Does mysql really not complain about this sort of thing? Am I alone in the world? )

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: