Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Clean theme
      2. If not already set, go to Frontpage settings enable Course Search Box as an option.
      3. Go to Frontpage and you should see the course search box.
      4. TEST that the label is in front (left) of the search box and not on top of it.
      5. Go to any course category and TEST that the same is true for the course search box, but this time in the navbar.
      Show
      Select Clean theme If not already set, go to Frontpage settings enable Course Search Box as an option. Go to Frontpage and you should see the course search box. TEST that the label is in front (left) of the search box and not on top of it. Go to any course category and TEST that the same is true for the course search box, but this time in the navbar.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39806_master

      Description

      The search box on the nav bar when viewing the list of courses in a category needs to be inline as currently the box overflows outside of the bar.

      As reported on https://moodle.org/mod/forum/discuss.php?d=229111, the fix is to add:

      fieldset.coursesearchbox label {
          display: inline;
      }
      

      to the 'moodle/forms.less' file.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Gareth J Barnard added a comment -

            Image 'bootst_issue.png' shows the issue.

            Show
            Gareth J Barnard added a comment - Image 'bootst_issue.png' shows the issue.
            Hide
            Gareth J Barnard added a comment -

            Dear Mary Evans,

            Sorry I could not do the patch as have been busy at iMoot2013. Shame not to see you there .

            Cheers,

            Gareth

            Show
            Gareth J Barnard added a comment - Dear Mary Evans , Sorry I could not do the patch as have been busy at iMoot2013. Shame not to see you there . Cheers, Gareth
            Hide
            Mary Evans added a comment - - edited

            I forgot all about the iMoot. Is that where everyone is? I thought it was a bit quiet.
            LOL

            Show
            Mary Evans added a comment - - edited I forgot all about the iMoot. Is that where everyone is? I thought it was a bit quiet. LOL
            Hide
            Gareth J Barnard added a comment -

            I think so

            Show
            Gareth J Barnard added a comment - I think so
            Hide
            Damyon Wiese added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Hi Mary,

            Thanks - i've integrated this now to master and 25.

            Show
            Dan Poltawski added a comment - Hi Mary, Thanks - i've integrated this now to master and 25.
            Hide
            Dan Poltawski added a comment -

            Hmm...... After integrating this I noticed that we have an ..invisiblefieldset, which in base does:

            invisiblefieldset {display:inline;border-width:0;padding:0;margin:0;}
            

            But in bootstrap its nowhere to be seen, just wondering if we should be fixing this in that class instead - there is mention of it in theme/bootstrapbase/less/moodle/undo.less

            Show
            Dan Poltawski added a comment - Hmm...... After integrating this I noticed that we have an ..invisiblefieldset, which in base does: invisiblefieldset {display:inline;border-width:0;padding:0;margin:0;} But in bootstrap its nowhere to be seen, just wondering if we should be fixing this in that class instead - there is mention of it in theme/bootstrapbase/less/moodle/undo.less
            Hide
            Gareth J Barnard added a comment -

            But Dan Poltawski the solution pertains to forms which is why I chose 'forms.less' and the trouble with 'invisiblefieldset' is that it comes with baggage which I think would obscure the issue. In 'undo.less' it states 'some very targetted corrections to roll back nameclashes between Moodle and Bootstrap like .row, .label, .content, .controls' but this is not a clash, rather than an enhancement where we have a Moodle specific component that has not been styled correctly to fit in line with Bootstrap as I imagine is what the 'moodle' folder is for.

            Show
            Gareth J Barnard added a comment - But Dan Poltawski the solution pertains to forms which is why I chose 'forms.less' and the trouble with 'invisiblefieldset' is that it comes with baggage which I think would obscure the issue. In 'undo.less' it states 'some very targetted corrections to roll back nameclashes between Moodle and Bootstrap like .row, .label, .content, .controls' but this is not a clash, rather than an enhancement where we have a Moodle specific component that has not been styled correctly to fit in line with Bootstrap as I imagine is what the 'moodle' folder is for.
            Hide
            Dan Poltawski added a comment -

            Gareth: I agree with the location of your change.

            But my point is in base this display:inline is done using the invisible fieldset, so all the places in Moodle where we ued invisiblefieldset will be getting that. Where as in bootstrap base that is not ther, so all over Moodle people will be using invisiblefieldset and it works differently in base and boostrapbase, so if we are to continue from this then there will be a CSS rule addded fixing everything in bootstrap to match base, rather than just the one in the inviisblefieldset.

            Show
            Dan Poltawski added a comment - Gareth: I agree with the location of your change. But my point is in base this display:inline is done using the invisible fieldset, so all the places in Moodle where we ued invisiblefieldset will be getting that. Where as in bootstrap base that is not ther, so all over Moodle people will be using invisiblefieldset and it works differently in base and boostrapbase, so if we are to continue from this then there will be a CSS rule addded fixing everything in bootstrap to match base, rather than just the one in the inviisblefieldset.
            Hide
            Jason Fowler added a comment -

            Works perfectly.

            Show
            Jason Fowler added a comment - Works perfectly.
            Hide
            Mary Evans added a comment -

            @Dan:
            Can you open new issue for that then I can add it into bootstrapbase?

            Show
            Mary Evans added a comment - @Dan: Can you open new issue for that then I can add it into bootstrapbase?
            Hide
            Dan Poltawski added a comment - - edited

            Yep, thanks Mary - MDL-39931

            Show
            Dan Poltawski added a comment - - edited Yep, thanks Mary - MDL-39931
            Hide
            Damyon Wiese added a comment -

            Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers!

            Regards, Damyon

            Show
            Damyon Wiese added a comment - Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers! Regards, Damyon

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: