Moodle
  1. Moodle
  2. MDL-38856 META: Issues around Bootstrapbase and Clean theme
  3. MDL-39819

Fix icon alignment in filepicker

        Details

        • Type: Sub-task Sub-task
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.5, 2.6
        • Fix Version/s: 2.5.1
        • Component/s: Filepicker, Themes
        • Labels:
        • Testing Instructions:
          Hide
          1. Apply the patch.
          2. Select the 'Clean' theme.
          3. On a course add an file submissions assignment.
          4. Open up that assignment as a student on the course and click on 'Add submission'.
          5. Drag and drop a file to upload.
          6. Using the window resizing control gradually reduce the screen width until the 'Display folder icons' are forced onto the next line because of lack of space. Observe that the containing box expands to accommodate without rendering a line underneath them.
          Show
          Apply the patch. Select the 'Clean' theme. On a course add an file submissions assignment. Open up that assignment as a student on the course and click on 'Add submission'. Drag and drop a file to upload. Using the window resizing control gradually reduce the screen width until the 'Display folder icons' are forced onto the next line because of lack of space. Observe that the containing box expands to accommodate without rendering a line underneath them.
        • Workaround:
          Hide

          None

          Show
          None
        • Affected Branches:
          MOODLE_25_STABLE, MOODLE_26_STABLE
        • Fixed Branches:
          MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          wip-MDL-39819_master
        • Pull Master Diff URL:

          Description

          See attachment.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Gareth J Barnard added a comment -

              Screen shot 'mdl-39819-solution.png' shows the solution I've come up with.

              Show
              Gareth J Barnard added a comment - Screen shot 'mdl-39819-solution.png' shows the solution I've come up with.
              Hide
              Permalink
              Gareth J Barnard added a comment -

              Dear Mary Evans,

              The solution to this that I have come up with involves adding:

              overflow: hidden;

              To the '.filemanager-toolbar' class in the file 'filemanager.less', but whilst searching I also found the same class in 'filemanager.css' of the 'base' theme and it was lacking the same thing. So will that need the same fix too? If so as this is a Bootstrap sub-task should it be a separate issue?

              Cheers,

              Gareth

              Show
              Gareth J Barnard added a comment - Dear Mary Evans , The solution to this that I have come up with involves adding: overflow: hidden; To the '.filemanager-toolbar' class in the file 'filemanager.less', but whilst searching I also found the same class in 'filemanager.css' of the 'base' theme and it was lacking the same thing. So will that need the same fix too? If so as this is a Bootstrap sub-task should it be a separate issue? Cheers, Gareth
              Hide
              Permalink
              Dan Poltawski added a comment -

              Hi Gareth,

              I think that you are right to pickup the issue about base, but as far as I can tell the filemanager is forced to a fixed width in base so we can't do the same thing (or at least I couldn't find a way to reproduce your issue). So I suppose this fix for boostrapbase is fine.

              thanks!

              Show
              Dan Poltawski added a comment - Hi Gareth, I think that you are right to pickup the issue about base, but as far as I can tell the filemanager is forced to a fixed width in base so we can't do the same thing (or at least I couldn't find a way to reproduce your issue). So I suppose this fix for boostrapbase is fine. thanks!
              Hide
              Permalink
              Dan Poltawski added a comment -

              Integrated to master and 25 - thanks Gareth!

              Show
              Dan Poltawski added a comment - Integrated to master and 25 - thanks Gareth!
              Hide
              Permalink
              Petr Skoda added a comment - - edited

              In Safari it went to two lines keeping the line underneath, in chrome it stayed on one line, two very small lines in Firefox - so I guess it works fine, thanks!

              Show
              Petr Skoda added a comment - - edited In Safari it went to two lines keeping the line underneath, in chrome it stayed on one line, two very small lines in Firefox - so I guess it works fine, thanks!
              Hide
              Permalink
              Dan Poltawski added a comment - 

              Feature: Thanks to our superb contributors
              		 
                In order to make Moodle better
              		 
                As an integrator
              		 
                I need to thank all our contributors
              		 
               
              		 
                Scenario: Dan thanks you all
              		 
                  Given I log in as "dan"
              		 
                  And I see "lots of fixed issues"
              		 
                  When I follow "Close integrated issues"
              		 
                  Then I should see "Lots of thanks to all our contributors"

              Your changes are upstream

              Show
              Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors   Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: