Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      NOTE FROM DAN: we need a bit of expository testing on this change in 2.5, to check for regressions with the following as a guideline:

      1. This change requires testing of a range of different page layouts using the clean theme and the standard theme (to check for regressions)
      2. For each of the following pages, check that the layout looks the same as before the patch, no javascript errors are thrown, and the block regions function correctly (including dragging and dropping blocks to empty regions).
        1. Front page
        2. Login page
        3. Course page
        4. Admin page(s)
        5. Page with an embedded iframe
        6. Safe browser page (quiz)
      3. Confirm behat is passing all tests.
      Show
      NOTE FROM DAN: we need a bit of expository testing on this change in 2.5, to check for regressions with the following as a guideline: This change requires testing of a range of different page layouts using the clean theme and the standard theme (to check for regressions) For each of the following pages, check that the layout looks the same as before the patch, no javascript errors are thrown, and the block regions function correctly (including dragging and dropping blocks to empty regions). Front page Login page Course page Admin page(s) Page with an embedded iframe Safe browser page (quiz) Confirm behat is passing all tests.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-39824-m26

      Description

      This is a collection of improvements raised in a chat. The general goal is to simplify the themes by removing logic from the layout files.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  8 Vote for this issue
                  Watchers:
                  20 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    8/Jul/13