Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39824

Simplification of themes

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.5
    • 2.5.1
    • Themes
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • wip-MDL-39824-m26
    • Hide

      NOTE FROM DAN: we need a bit of expository testing on this change in 2.5, to check for regressions with the following as a guideline:

      1. This change requires testing of a range of different page layouts using the clean theme and the standard theme (to check for regressions)
      2. For each of the following pages, check that the layout looks the same as before the patch, no javascript errors are thrown, and the block regions function correctly (including dragging and dropping blocks to empty regions).
        1. Front page
        2. Login page
        3. Course page
        4. Admin page(s)
        5. Page with an embedded iframe
        6. Safe browser page (quiz)
      3. Confirm behat is passing all tests.
      Show
      NOTE FROM DAN: we need a bit of expository testing on this change in 2.5, to check for regressions with the following as a guideline: This change requires testing of a range of different page layouts using the clean theme and the standard theme (to check for regressions) For each of the following pages, check that the layout looks the same as before the patch, no javascript errors are thrown, and the block regions function correctly (including dragging and dropping blocks to empty regions). Front page Login page Course page Admin page(s) Page with an embedded iframe Safe browser page (quiz) Confirm behat is passing all tests.

    Description

      This is a collection of improvements raised in a chat. The general goal is to simplify the themes by removing logic from the layout files.

      Attachments

        Issue Links

          blocks

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-40065 Bootstrap Theme always sends content to "side-pre", even when there isn't one

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40722 Clean theme: Resizing 3 column page with all blocks on the left is not displayed correctly

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40316 Logo and footnote missed from the clean layout files.

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-44074 MDL-39824 missed setting correct span calculations for 768px-979px and 1200px+ displays.

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-49165 theme option 'langmenu' is not respected in bootstrapbase-based themes

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40174 Navbar disappears if user is enrolled in a course

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40204 Bootstrap three column layout does not render correctly in RTL when only one block.

          • Major - Major loss of function, incorrect output
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42852 Blocks disappear in Clean in RTL

          • Major - Major loss of function, incorrect output
          • Closed
          will help resolve

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-40067 Bootstrap Clean Theme loses blocks when $THEME->layout side-pre and side-post are swapped

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              samhemelryk Sam Hemelryk
              damyon Damyon Wiese
              Damyon Wiese Damyon Wiese
              Dan Poltawski Dan Poltawski
              David Monllaó David Monllaó
              Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              8 Vote for this issue
              Watchers:
              20 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                8/Jul/13