Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39824

Simplification of themes

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.5.1
    • 2.5
    • Themes
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • wip-MDL-39824-m26
    • Hide

      NOTE FROM DAN: we need a bit of expository testing on this change in 2.5, to check for regressions with the following as a guideline:

      1. This change requires testing of a range of different page layouts using the clean theme and the standard theme (to check for regressions)
      2. For each of the following pages, check that the layout looks the same as before the patch, no javascript errors are thrown, and the block regions function correctly (including dragging and dropping blocks to empty regions).
        1. Front page
        2. Login page
        3. Course page
        4. Admin page(s)
        5. Page with an embedded iframe
        6. Safe browser page (quiz)
      3. Confirm behat is passing all tests.
      Show
      NOTE FROM DAN: we need a bit of expository testing on this change in 2.5, to check for regressions with the following as a guideline: This change requires testing of a range of different page layouts using the clean theme and the standard theme (to check for regressions) For each of the following pages, check that the layout looks the same as before the patch, no javascript errors are thrown, and the block regions function correctly (including dragging and dropping blocks to empty regions). Front page Login page Course page Admin page(s) Page with an embedded iframe Safe browser page (quiz) Confirm behat is passing all tests.

      This is a collection of improvements raised in a chat. The general goal is to simplify the themes by removing logic from the layout files.

        1. MDL-39824-block-content-width-mobile-simulated.jpg
          MDL-39824-block-content-width-mobile-simulated.jpg
          23 kB
        2. MDL-39824-ERROR-region-side-post.jpg
          MDL-39824-ERROR-region-side-post.jpg
          64 kB
        1.
        		 Add a renderer method to render a list of classes for the body Sub-task Closed Unassigned
        2.
        		 Change all calls to $PAGE in layout files to call a method on the renderer. Sub-task Closed Unassigned
        3.
        		 Replace blocks_for_region call with new method block_container Sub-task Closed Unassigned
        4.
        		 Fix DND code so it is not dependent on the structure of the html in the layout file. Sub-task Closed Unassigned
        5.
        		 Find a solution to handling RTL switching in CSS Sub-task Closed Unassigned
        6.
        		 Simplify the layouts for the bootstrapbase and clean themes Sub-task Closed Unassigned

            samhemelryk Sam Hemelryk
            damyon Damyon Wiese
            Damyon Wiese Damyon Wiese
            Dan Poltawski Dan Poltawski
            David Monllaó David Monllaó
            Votes:
            8 Vote for this issue
            Watchers:
            20 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.