Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/gjb2048/moodle.git
Pull Main Branch:
wip-~~MDL-39836~~_master
Pull Main Diff URL:
https://github.com/gjb2048/moodle/compare/master...wip-MDL-39836_master
Testing Instructions:
Hide

Select 'clean' theme as the site theme.

Observe that the login 'You are logged in as' Username is the same colour as the normal links as the main menu, grey, and that when hovered over turn to a darker shade of grey.

Select 'Clean' Custom settings (under site appearance) click on the 'Invert navbar' setting and save the settings.

Observe that the text on the navigation bar for the user name is readable (light grey on black) and when hovered over (white on black).
Show
Select 'clean' theme as the site theme. Observe that the login 'You are logged in as' Username is the same colour as the normal links as the main menu, grey, and that when hovered over turn to a darker shade of grey. Select 'Clean' Custom settings (under site appearance) click on the 'Invert navbar' setting and save the settings. Observe that the text on the navigation bar for the user name is readable (light grey on black) and when hovered over (white on black).

On the navigation bar the text for the username is unreadable when the colours are inverted in the Clean theme.

The solution is to add the following 'less' to the '/theme/bootstrapbase/less/moodle/modules.less' file:

.navbar-inverse {

  .logininfo a {

      color: @navbarInverseLinkColor;

  .logininfo a:hover {

      background-color: @navbarInverseLinkBackgroundHover; // "transparent" is default to differentiate :hover/:focus from .active

      color: @navbarInverseLinkColorHover;

blocks

MDL-39868 Make Clean theme 'You are not logged in (Login)' link more prominant in the top navbar.

Participants:: Damyon Wiese, Eloy Lafuente (stronk7), Gareth J Barnard, Jason Fowler, Mary Evans