Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39824 Simplification of themes
  3. MDL-39871

Find a solution to handling RTL switching in CSS

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Bootstrapbase theme
      2. Make a note of which blocks are currently in the side columns (left & right).
      3. Change to a RTL language like Hebrew (he) or Arabic(ar).
      4. TEST that the blocks are now reversed. What was in the left column is now in the right column and visa versa.
      5. With editing enabled move all blocks to the one side. Turn editing off.
      6. TEST that the page displays accordingly.
      7. Change language back to English and TEST that the side blocks now display on the opposite side of the page.
      Show
      Select Bootstrapbase theme Make a note of which blocks are currently in the side columns (left & right). Change to a RTL language like Hebrew (he) or Arabic(ar). TEST that the blocks are now reversed. What was in the left column is now in the right column and visa versa. With editing enabled move all blocks to the one side. Turn editing off. TEST that the page displays accordingly. Change language back to English and TEST that the side blocks now display on the opposite side of the page.
    • Affected Branches:
      MOODLE_25_STABLE

      Description

      There are hooks in most themes and in some places in core that try to handle switching blocks for rtl languages.
      Really this is something that would be much better achieved in CSS as not all cases are as clear cut as side-pre and side-post.
      Having a CSS solution would certainly be more autonomous and facilitate and easier solution.
      With the introduction of bootstrap new possibilities have arisen and certainly if bootstrap makes it to core having a bootstrap solution would be excellent.
      Damyon pointed out that there has been discussion (https://github.com/twitter/bootstrap/pull/6409#issuecomment-11725361) in the bootstrap community about this and that there is already a pull request for RTL changes: https://github.com/twitter/bootstrap/pull/6423

        Attachments

        1. Screen Shot 2013-09-25 at 1.12.26 PM.png
          14 kB
          Barbara Ramiro
        2. Screen Shot 2013-09-25 at 1.37.36 PM.png
          20 kB
          Barbara Ramiro
        3. Screen Shot 2013-09-25 at 1.37.45 PM.png
          21 kB
          Barbara Ramiro
        4. Screen Shot 2013-09-25 at 1.58.34 PM.png
          36 kB
          Barbara Ramiro
        5. Screen Shot 2013-09-25 at 1.59.05 PM.png
          30 kB
          Barbara Ramiro
        6. Screen Shot 2013-09-25 at 11.31.52 AM.png
          11 kB
          Barbara Ramiro
        7. Screen Shot 2013-09-25 at 11.32.29 AM.png
          13 kB
          Barbara Ramiro
        8. Screen Shot 2013-09-25 at 12.11.36 PM.png
          49 kB
          Barbara Ramiro
        9. Screen Shot 2013-09-25 at 12.17.17 PM.png
          15 kB
          Barbara Ramiro
        10. Screen Shot 2013-09-25 at 12.30.11 PM.png
          30 kB
          Barbara Ramiro
        11. Screen Shot 2013-09-25 at 12.31.12 PM.png
          11 kB
          Barbara Ramiro
        12. Screen Shot 2013-09-25 at 12.49.21 PM.png
          48 kB
          Barbara Ramiro

          Activity

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: