Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39876

Change get_record('course') calls to use new get_course API

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6.5
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      This change is supposed to be safe because it's based around search/replace, but could possibly cause minor breakage in a wide range of areas.

      As a result, these testing instructions are not exhaustive and basically cover shallow usage through a cross-section of affected areas.

      In all cases the test is basically, go do something, and see if there are any errors or whatever. If an error occurs, check whether it also occurred without this patch (i.e. it may be unrelated) or is a result of the patch. Because this a wide range of stuff, it's likely there might be some unrelated errors discovered.

      1. View a course page. Edit course settings and save changes. (This hits modinfolib and related.)

      2. Do a backup and a restore of a small course.

      3. Add the RSS client block to a sample course. Edit the RSS feed list and add a feed to it.

      4. Go to the calendar and add a new event.

      5. On a course, go to the participants screen and view a user's profile. View their full profile.

      6. Go to the enrolments screen and enrol somebody.

      7. Use the gradebook to add an outcome (enable outcomes if necessary first).

      8. Create a group and add a user to it.

      9. Add an assignment module with default settings (or use existing) and click into it.

      10. For the following modules, either add a new instance with minimal settings, or use an existing module; click into its view page:

      a. Book
      b. Folder
      c. Lesson
      d. Page
      e. File (resource)
      f. URL
      g. Wiki
      h. Workshop

      11. Have a look at the logs report for the course.

      Show
      This change is supposed to be safe because it's based around search/replace, but could possibly cause minor breakage in a wide range of areas. As a result, these testing instructions are not exhaustive and basically cover shallow usage through a cross-section of affected areas. In all cases the test is basically, go do something, and see if there are any errors or whatever. If an error occurs, check whether it also occurred without this patch (i.e. it may be unrelated) or is a result of the patch. Because this a wide range of stuff, it's likely there might be some unrelated errors discovered. 1. View a course page. Edit course settings and save changes. (This hits modinfolib and related.) 2. Do a backup and a restore of a small course. 3. Add the RSS client block to a sample course. Edit the RSS feed list and add a feed to it. 4. Go to the calendar and add a new event. 5. On a course, go to the participants screen and view a user's profile. View their full profile. 6. Go to the enrolments screen and enrol somebody. 7. Use the gradebook to add an outcome (enable outcomes if necessary first). 8. Create a group and add a user to it. 9. Add an assignment module with default settings (or use existing) and click into it. 10. For the following modules, either add a new instance with minimal settings, or use an existing module; click into its view page: a. Book b. Folder c. Lesson d. Page e. File (resource) f. URL g. Wiki h. Workshop 11. Have a look at the logs report for the course.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-39876-master

      Description

      Replace existing calls to get_record('course', array('id' => $whatever)) with new get_course API (if MDL-39723 is integrated).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Sep/14