Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Switch to clean theme, purge caches

      1. Find the following forms and look for visual problems:
      2. forum search block and forum search page
      3. Quiz editing page (ordering questions)
      Show
      Switch to clean theme, purge caches Find the following forms and look for visual problems: forum search block and forum search page Quiz editing page (ordering questions)
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
      git@github.com:lazydaisy/moodle.git
    • Pull Master Branch:

      Description

      As discovered in MDL-39806 rules for invisiblefieldset are missing from boostrap, for example the display:inline.

      This is causing differences between base and bootstrapbase for some forms between the two. Ideally we shouldn't need to write specific rules in bootstrap base for things which are working OK in base from that class.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Dan Poltawski added a comment -

            Integrated to master and 25 - thanks

            Show
            Dan Poltawski added a comment - Integrated to master and 25 - thanks
            Hide
            Dan Poltawski added a comment -

            I had to add a commit to fix the built file as recess was run without --compress

            Show
            Dan Poltawski added a comment - I had to add a commit to fix the built file as recess was run without --compress
            Hide
            Petr Skoda added a comment -

            Clean looks cool, thanks!

            Show
            Petr Skoda added a comment - Clean looks cool, thanks!
            Hide
            Dan Poltawski added a comment -

            Feature: Thanks to our superb contributors
              In order to make Moodle better
              As an integrator
              I need to thank all our contributors
             
              Scenario: Dan thanks you all
                Given I log in as "dan"
                And I see "lots of fixed issues"
                When I follow "Close integrated issues"
                Then I should see "Lots of thanks to all our contributors"
            

            Your changes are upstream

            Show
            Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors   Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream
            Hide
            David Scotson added a comment -

            The diff no longer points to anything so I have no idea what this change involved but I'd just like to note that .invisiblefieldset is a very poor CSS classname, even when it's being used to control whether the border placed around a form's fieldset is displayed or not (which is just vaguely acceptable if you squint a bit at it). Using it to control whether part of a form is displayed inline or not is really stretching things.

            I was kind of hoping the adoption of Bootstrap would lead to such things being identified and fixed, so seeing them all ported into Bootstrapbase without much reflection on whether they're a good thing or not is a bit disappointing.

            Show
            David Scotson added a comment - The diff no longer points to anything so I have no idea what this change involved but I'd just like to note that .invisiblefieldset is a very poor CSS classname, even when it's being used to control whether the border placed around a form's fieldset is displayed or not (which is just vaguely acceptable if you squint a bit at it). Using it to control whether part of a form is displayed inline or not is really stretching things. I was kind of hoping the adoption of Bootstrap would lead to such things being identified and fixed, so seeing them all ported into Bootstrapbase without much reflection on whether they're a good thing or not is a bit disappointing.
            Hide
            Petr Skoda added a comment -

            the diff are there for integration only, please search git history for MDL-xxx to see what got integrated

            Show
            Petr Skoda added a comment - the diff are there for integration only, please search git history for MDL-xxx to see what got integrated
            Hide
            Petr Skoda added a comment -

            Martin invented the .invisiblefieldset to work around xhtml strict validation problems, some of us did not like it. I personally believe it is better to use normal divs there because the fieldset should be IMO used for something else.

            Show
            Petr Skoda added a comment - Martin invented the .invisiblefieldset to work around xhtml strict validation problems, some of us did not like it. I personally believe it is better to use normal divs there because the fieldset should be IMO used for something else.
            Hide
            Mary Evans added a comment -
            Show
            Mary Evans added a comment - @David, the commit for this can be found here... https://github.com/lazydaisy/moodle/commit/947483327f899540cc079e2d0ad7b0189bae28f7

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: