Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39942

Discuss this topic link on the Site News Forum - should not appear all the time

    Details

    • Testing Instructions:
      Hide

      Display Site News on Front Page and create a post.
      Login as site admin to see "Discuss this topic" link.
      Login is normal user. You should not see "Discuss this topic".
      View the page anonymously. You should not see "Discuss this topic".

      Show
      Display Site News on Front Page and create a post. Login as site admin to see "Discuss this topic" link. Login is normal user. You should not see "Discuss this topic". View the page anonymously. You should not see "Discuss this topic".
    • Workaround:
      Hide

      You can hide the discussion link from everyone using CSS.

      .path-site .forumpost .link

      { display: none; }
      Show
      You can hide the discussion link from everyone using CSS. .path-site .forumpost .link { display: none; }
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-39942-master

      Description

      "Discuss this topic" link appears for the Site News Forum for everyone (authenticated, non-authenticated users, all roles), even if all possible permissions are set to Prevent discussions and replies.

      Once person clicks on the link, he can see the post, with no Reply link there (which is how it is supposed to be)
      See screenshots.

        Gliffy Diagrams

        1. discuss.png
          15 kB
        2. noreply.png
          11 kB

          Activity

          Hide
          marycooch Mary Cooch added a comment -

          Oh dear! I have just been searching to get rid of this for guests on a front page of Moodle and I arrived at this tracker issue.

          Show
          marycooch Mary Cooch added a comment - Oh dear! I have just been searching to get rid of this for guests on a front page of Moodle and I arrived at this tracker issue.
          Hide
          littleman Sébastien Petit added a comment -

          pheww subscribed here just for that ^^

          Show
          littleman Sébastien Petit added a comment - pheww subscribed here just for that ^^
          Hide
          kwiliarty Kevin Wiliarty added a comment - - edited

          Maybe this is a fix... See the pull branches above.

          Show
          kwiliarty Kevin Wiliarty added a comment - - edited Maybe this is a fix... See the pull branches above.
          Hide
          tsala Helen Foster added a comment -

          Thanks Kevin for your patch and apologies for this issue not getting any attention. Hopefully a developer will notice the patch label that I am adding and review your suggested fix.

          Also adding https://moodle.org/news/ as a URL showing the problem.

          Show
          tsala Helen Foster added a comment - Thanks Kevin for your patch and apologies for this issue not getting any attention. Hopefully a developer will notice the patch label that I am adding and review your suggested fix. Also adding https://moodle.org/news/ as a URL showing the problem.
          Hide
          kwiliarty Kevin Wiliarty added a comment -

          Thanks, Helen. I know it's minor, but it would be nice to have it fixed. I'll add pull and diff URL's for 2.6 and master as well.

          Show
          kwiliarty Kevin Wiliarty added a comment - Thanks, Helen. I know it's minor, but it would be nice to have it fixed. I'll add pull and diff URL's for 2.6 and master as well.
          Hide
          tsala Helen Foster added a comment -

          Thanks a lot Kevin, requesting peer review on your behalf.

          Show
          tsala Helen Foster added a comment - Thanks a lot Kevin, requesting peer review on your behalf.
          Hide
          cibot CiBoT added a comment -

          Results for MDL-39942

          Show
          cibot CiBoT added a comment - Results for MDL-39942 Remote repository: https://github.com/kwiliarty/moodle Remote branch https://github.com/kwiliarty/moodle/tree/wip-MDL-39942-MOODLE_24_STABLE to be integrated into upstream MOODLE_24_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/917 Error: Unable to fetch information from https://github.com/kwiliarty/moodle/tree/wip-MDL-39942-MOODLE_24_STABLE branch at https://github.com/kwiliarty/moodle . Remote branch https://github.com/kwiliarty/moodle/tree/wip-MDL-39942-MOODLE_25_STABLE to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/918 Error: Unable to fetch information from https://github.com/kwiliarty/moodle/tree/wip-MDL-39942-MOODLE_25_STABLE branch at https://github.com/kwiliarty/moodle . Remote branch https://github.com/kwiliarty/moodle/tree/wip-MDL-39942-MOODLE_26_STABLE to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/919 Error: Unable to fetch information from https://github.com/kwiliarty/moodle/tree/wip-MDL-39942-MOODLE_26_STABLE branch at https://github.com/kwiliarty/moodle . Remote branch https://github.com/kwiliarty/moodle/tree/wip-MDL-39942-master to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/920 Error: Unable to fetch information from https://github.com/kwiliarty/moodle/tree/wip-MDL-39942-master branch at https://github.com/kwiliarty/moodle .
          Hide
          kwiliarty Kevin Wiliarty added a comment -

          Added .git to the end of the URL for my remote repository. I'm not sure that's what's required. If it's something else, please let me know.

          Show
          kwiliarty Kevin Wiliarty added a comment - Added .git to the end of the URL for my remote repository. I'm not sure that's what's required. If it's something else, please let me know.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment - - edited

          Hi Kevin,

          I think the problem is that, in the "Pull X.Y Branch" fields you have to introduce the branch names not the branch urls. So, for example, the "Pull Master Branch" should be "wip-MDL-39942-master" instead of the current url there.

          About the "Pull from repository" field, it must be the url of your repo (github shows it to you in the "HTTPS clone URL" field of your moodle clone), in this case: "https://github.com/kwiliarty/moodle.git" (although I think git is clever enough to do its work if the .git is missing).

          And finally, the "Pull X.Y Diff URL" fields, they are correct already, they must be urls and point to the complete diff of your changes.

          Hope it helps, thanks for your collaboration, ciao

          Edited: s/Elena/Kevin (sorry for the confusion, heh)

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - - edited Hi Kevin, I think the problem is that, in the "Pull X.Y Branch" fields you have to introduce the branch names not the branch urls. So, for example, the "Pull Master Branch" should be "wip- MDL-39942 -master" instead of the current url there. About the "Pull from repository" field, it must be the url of your repo (github shows it to you in the "HTTPS clone URL" field of your moodle clone), in this case: "https://github.com/kwiliarty/moodle.git" (although I think git is clever enough to do its work if the .git is missing). And finally, the "Pull X.Y Diff URL" fields, they are correct already, they must be urls and point to the complete diff of your changes. Hope it helps, thanks for your collaboration, ciao Edited: s/Elena/Kevin (sorry for the confusion, heh)
          Hide
          salvetore Michael de Raadt added a comment -

          Hi, Kevin.

          Thanks for working on this. I've set you as the assignee on this issue. Hopefully it will be peer reviewed soon.

          Show
          salvetore Michael de Raadt added a comment - Hi, Kevin. Thanks for working on this. I've set you as the assignee on this issue. Hopefully it will be peer reviewed soon.
          Hide
          kwiliarty Kevin Wiliarty added a comment -

          Thanks for pointing me in the right direction, Eloy. I've updated the branch fields now.

          Show
          kwiliarty Kevin Wiliarty added a comment - Thanks for pointing me in the right direction, Eloy. I've updated the branch fields now.
          Hide
          cibot CiBoT added a comment -

          Results for MDL-39942

          Show
          cibot CiBoT added a comment - Results for MDL-39942 Remote repository: https://github.com/kwiliarty/moodle.git Remote branch wip- MDL-39942 -MOODLE_24_STABLE to be integrated into upstream MOODLE_24_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1040 Warning: The wip- MDL-39942 -MOODLE_24_STABLE branch at https://github.com/kwiliarty/moodle.git has not been rebased recently (>20 days ago). Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1040/artifact/work/smurf.html Remote branch wip- MDL-39942 -MOODLE_25_STABLE to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1041 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1041/artifact/work/smurf.html Remote branch wip- MDL-39942 -MOODLE_26_STABLE to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1042 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1042/artifact/work/smurf.html Remote branch wip- MDL-39942 -master to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1043 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1043/artifact/work/smurf.html
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          Looks good, pushing for integration.
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - Looks good, pushing for integration. Thanks
          Hide
          cibot CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Kevin this has been integrated now.

          Noting it has landed to 25, 26, and master. 24 is only receiving security patches now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Kevin this has been integrated now. Noting it has landed to 25, 26, and master. 24 is only receiving security patches now.
          Hide
          skodak Petr Skoda added a comment -

          works fine,
          thanks

          Show
          skodak Petr Skoda added a comment - works fine, thanks
          Hide
          kwiliarty Kevin Wiliarty added a comment -

          So glad to hear it. My thanks to all of you, too.

          Show
          kwiliarty Kevin Wiliarty added a comment - So glad to hear it. My thanks to all of you, too.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          This weeks weekly release is now available and includes your code.
          A big pat on the back to you again for once more being a cog in the Moodle machine.

          Best wishes, the Moodle integration team.

          Show
          samhemelryk Sam Hemelryk added a comment - This weeks weekly release is now available and includes your code. A big pat on the back to you again for once more being a cog in the Moodle machine. Best wishes, the Moodle integration team.

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14