Moodle

Multiple-choice multi-response is_same_response check fails for blank responses

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.7, 2.4.4, 2.5
  • Fix Version/s: 2.3.8, 2.4.5
  • Component/s: Questions
  • Labels:

Description

To reproduce:

1. Preview a multiple-choice multi-response question.
2. Just click Save without selecting a response.

Expected result: The question state is not changed.

Actual result: An extra question step is created. "Saved {$a}" in the response history.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Note that this bug does not cause any incorrect processing of quiz responses. It is just technically wrong and so should be fixed.

Show
Tim Hunt added a comment - Note that this bug does not cause any incorrect processing of quiz responses. It is just technically wrong and so should be fixed.
Hide
Permalink
Tim Hunt added a comment -

Submitting for integration.

Show
Tim Hunt added a comment - Submitting for integration.
Hide
Permalink
Dan Poltawski added a comment -

Should this be backported to 2.3?

Show
Dan Poltawski added a comment - Should this be backported to 2.3?
Hide
Permalink
Tim Hunt added a comment -

When I did this, I was confused about the support status of 2.3. This is not a big deal. The only problem caused is one extra line in the response history table for teachers. No other harm is done. So, 2.4-master would be fine, or, if you prefer, you could cherry-pick it yourself. Either is fine, I think.

Show
Tim Hunt added a comment - When I did this, I was confused about the support status of 2.3. This is not a big deal. The only problem caused is one extra line in the response history table for teachers. No other harm is done. So, 2.4-master would be fine, or, if you prefer, you could cherry-pick it yourself. Either is fine, I think.
Hide
Permalink
Dan Poltawski added a comment -

Thanks, I will cherry-pick it.

Do you understand the support status now? (We support a year after release and then allow until the next scheduled point release so that all the users can ge the fixes).

Show
Dan Poltawski added a comment - Thanks, I will cherry-pick it. Do you understand the support status now? (We support a year after release and then allow until the next scheduled point release so that all the users can ge the fixes).
Hide
Permalink
Dan Poltawski added a comment -

Integrated to master, 25, 24, 23, thanks Tim

Show
Dan Poltawski added a comment - Integrated to master, 25, 24, 23, thanks Tim
Hide
Permalink
Tim Hunt added a comment -

Yes, Dan, I do understand. Thanks for checking. Just after I had got this wrong, there was a discussion in developer's chat that made it clear, but I did not bother to come back here to to create the extra branch. (I just not the next bug fix right.)

Show
Tim Hunt added a comment - Yes, Dan, I do understand. Thanks for checking. Just after I had got this wrong, there was a discussion in developer's chat that made it clear, but I did not bother to come back here to to create the extra branch. (I just not the next bug fix right.)
Hide
Permalink
Mark Nelson added a comment -

Hi Tim, works as expected, thanks.

Show
Mark Nelson added a comment - Hi Tim, works as expected, thanks.
Hide
Permalink
Dan Poltawski added a comment - 
Feature: Thanks to our superb contributors
  In order to make Moodle better
  As an integrator
  I need to thank all our contributors

  Scenario: Dan thanks you all
    Given I log in as "dan"
    And I see "lots of fixed issues"
    When I follow "Close integrated issues"
    Then I should see "Lots of thanks to all our contributors"

Your changes are upstream

Show
Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: