[MDL-39945] Multiple-choice multi-response is_same_response check fails for blank responses - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3.7, 2.4.4, 2.5
Fix Version/s: 2.3.8, 2.4.5
Component/s: Questions
Labels:
- triaged

Testing Instructions:

Hide

1. Create a multiple-choice multi-response question.
2. Preview the question.
3. Make sure the preview options are such that the response history is visible. If not, change them.
4. Just click Save without selecting any choices.
5. The question state should not change. In particular, there should still ony be once step in the response history.

Expected result: The question state is not changed.

Show
1. Create a multiple-choice multi-response question. 2. Preview the question. 3. Make sure the preview options are such that the response history is visible. If not, change them. 4. Just click Save without selecting any choices. 5. The question state should not change. In particular, there should still ony be once step in the response history. Expected result: The question state is not changed.
Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-39945~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-39945

Description

To reproduce:

1. Preview a multiple-choice multi-response question.
2. Just click Save without selecting a response.

Expected result: The question state is not changed.

Actual result: An extra question step is created. "Saved {$a}" in the response history.

Gliffy Diagrams

Attachments

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tim Hunt added a comment - 30/May/13 5:47 PM

Note that this bug does not cause any incorrect processing of quiz responses. It is just technically wrong and so should be fixed.

Show

Tim Hunt added a comment - 30/May/13 5:47 PM Note that this bug does not cause any incorrect processing of quiz responses. It is just technically wrong and so should be fixed.

Hide

Permalink

Tim Hunt added a comment - 30/May/13 6:25 PM

Submitting for integration.

Show

Tim Hunt added a comment - 30/May/13 6:25 PM Submitting for integration.

Hide

Permalink

Dan Poltawski added a comment - 04/Jun/13 4:26 AM

Should this be backported to 2.3?

Show

Dan Poltawski added a comment - 04/Jun/13 4:26 AM Should this be backported to 2.3?

Hide

Permalink

Tim Hunt added a comment - 04/Jun/13 7:46 AM

When I did this, I was confused about the support status of 2.3. This is not a big deal. The only problem caused is one extra line in the response history table for teachers. No other harm is done. So, 2.4-master would be fine, or, if you prefer, you could cherry-pick it yourself. Either is fine, I think.

Show

Tim Hunt added a comment - 04/Jun/13 7:46 AM When I did this, I was confused about the support status of 2.3. This is not a big deal. The only problem caused is one extra line in the response history table for teachers. No other harm is done. So, 2.4-master would be fine, or, if you prefer, you could cherry-pick it yourself. Either is fine, I think.

Hide

Permalink

Dan Poltawski added a comment - 04/Jun/13 7:51 AM

Thanks, I will cherry-pick it.

Do you understand the support status now? (We support a year after release and then allow until the next scheduled point release so that all the users can ge the fixes).

Show

Dan Poltawski added a comment - 04/Jun/13 7:51 AM Thanks, I will cherry-pick it. Do you understand the support status now? (We support a year after release and then allow until the next scheduled point release so that all the users can ge the fixes).

Hide

Permalink

Dan Poltawski added a comment - 04/Jun/13 8:02 AM

Integrated to master, 25, 24, 23, thanks Tim

Show

Dan Poltawski added a comment - 04/Jun/13 8:02 AM Integrated to master, 25, 24, 23, thanks Tim

Hide

Permalink

Tim Hunt added a comment - 04/Jun/13 9:14 AM

Yes, Dan, I do understand. Thanks for checking. Just after I had got this wrong, there was a discussion in developer's chat that made it clear, but I did not bother to come back here to to create the extra branch. (I just not the next bug fix right.)

Show

Tim Hunt added a comment - 04/Jun/13 9:14 AM Yes, Dan, I do understand. Thanks for checking. Just after I had got this wrong, there was a discussion in developer's chat that made it clear, but I did not bother to come back here to to create the extra branch. (I just not the next bug fix right.)

Hide

Permalink

Mark Nelson added a comment - 05/Jun/13 7:00 AM

Hi Tim, works as expected, thanks.

Show

Mark Nelson added a comment - 05/Jun/13 7:00 AM Hi Tim, works as expected, thanks.

Hide

Permalink

Dan Poltawski added a comment - 06/Jun/13 5:22 AM

Feature: Thanks to our superb contributors

  In order to make Moodle better

  As an integrator

  I need to thank all our contributors

  Scenario: Dan thanks you all

    Given I log in as "dan"

    And I see "lots of fixed issues"

    When I follow "Close integrated issues"

    Then I should see "Lots of thanks to all our contributors"

Your changes are upstream

Show

Dan Poltawski added a comment - 06/Jun/13 5:22 AM Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream

People

Assignee:

Tim Hunt

Reporter:

Tim Hunt

Integrator:

Dan Poltawski

Tester:

Mark Nelson

Participants:

Dan Poltawski, Mark Nelson, Tim Hunt

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

30/May/13 5:45 PM

Updated:

06/Jun/13 5:22 AM

Resolved:

06/Jun/13 5:22 AM

Fix Release Date:

8/Jul/13