Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.3.7, 2.4.4, 2.5
-
Component/s: Questions
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
-
Fixed Branches:MOODLE_23_STABLE, MOODLE_24_STABLE
-
Pull from Repository:
-
Pull 2.4 Branch:
MDL-39945_24 -
Pull 2.4 Diff URL:
-
Pull 2.5 Branch:
MDL-39945_25 -
Pull 2.5 Diff URL:
-
Pull Master Branch:
-
Pull Master Diff URL:
-
Rank:50698
Description
To reproduce:
1. Preview a multiple-choice multi-response question.
2. Just click Save without selecting a response.
Expected result: The question state is not changed.
Actual result: An extra question step is created. "Saved {$a}" in the response history.
Activity
Should this be backported to 2.3?
When I did this, I was confused about the support status of 2.3. This is not a big deal. The only problem caused is one extra line in the response history table for teachers. No other harm is done. So, 2.4-master would be fine, or, if you prefer, you could cherry-pick it yourself. Either is fine, I think.
Thanks, I will cherry-pick it.
Do you understand the support status now? (We support a year after release and then allow until the next scheduled point release so that all the users can ge the fixes).
Integrated to master, 25, 24, 23, thanks Tim
Yes, Dan, I do understand. Thanks for checking. Just after I had got this wrong, there was a discussion in developer's chat that made it clear, but I did not bother to come back here to to create the extra branch. (I just not the next bug fix right.)
Hi Tim, works as expected, thanks.
Feature: Thanks to our superb contributors
In order to make Moodle better
As an integrator
I need to thank all our contributors
Scenario: Dan thanks you all
Given I log in as "dan"
And I see "lots of fixed issues"
When I follow "Close integrated issues"
Then I should see "Lots of thanks to all our contributors"
Your changes are upstream 
Note that this bug does not cause any incorrect processing of quiz responses. It is just technically wrong and so should be fixed.