[MDL-39945] Multiple-choice multi-response is_same_response check fails for blank responses - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-39945~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-39945
Testing Instructions:

Hide

1. Create a multiple-choice multi-response question.
2. Preview the question.
3. Make sure the preview options are such that the response history is visible. If not, change them.
4. Just click Save without selecting any choices.
5. The question state should not change. In particular, there should still ony be once step in the response history.

Expected result: The question state is not changed.

Show
1. Create a multiple-choice multi-response question. 2. Preview the question. 3. Make sure the preview options are such that the response history is visible. If not, change them. 4. Just click Save without selecting any choices. 5. The question state should not change. In particular, there should still ony be once step in the response history. Expected result: The question state is not changed.

To reproduce:

1. Preview a multiple-choice multi-response question.
2. Just click Save without selecting a response.

Expected result: The question state is not changed.

Actual result: An extra question step is created. "Saved {$a}" in the response history.

Component watchers:: Safat Shahin, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie