Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39949

Block without header causes JS error on page

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: JavaScript, Usability
    • Labels:
    • Testing Instructions:
      Hide

      Test 1

      1. Turn editing on for blocks
      2. Create a HTML block with quotes and double quotes in the title
      3. Hover over the Dock icon on the block, ensure the block's name is mentioned in the tool tip
      4. Turn editing on for blocks
      5. Hover over the Dock icon on the HTML block, ensure the block's name is mentioned in the tool tip

      Test 2

      1. Add a block that does not have a title to a course page
      2. Try to launch and use the activity chooser

      It should open and function without error.

      Show
      Test 1 Turn editing on for blocks Create a HTML block with quotes and double quotes in the title Hover over the Dock icon on the block, ensure the block's name is mentioned in the tool tip Turn editing on for blocks Hover over the Dock icon on the HTML block, ensure the block's name is mentioned in the tool tip Test 2 Add a block that does not have a title to a course page Try to launch and use the activity chooser It should open and function without error.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-39949-master
    • Story Points (Obsolete):
      3
    • Sprint:
      FRONTEND Sprint 1

      Description

      Updated description:

      Reporter noticed a Javascript error in some courses' pages in editing mode. It causes activity chooser to fail to work. If blocks without headings are removed, JS code starts working again so presumably presence of those blocks causes the error.


      Original description:

      Thread here: https://moodle.org/mod/forum/discuss.php?d=228086#p997260

      Upgraded to 2.5 from 2.3 this week, initially used an incomplete zip file. Subsequently corrected. Since then the Activity Chooser behaves inconsistently in courses.

      Case 1
      In some courses it is greyed out. Switching it off allows the drop-down lists to work - but only if you quickly select an option, otherwise it fails - jumpto.php appears to get an empty string in this case and also drag and drop of course items does not work.

      Case 2
      In some other courses, using the Activity Chooser to select an activity or resource generates an error on selection of the activity or resource. Switching off the Activity chooser allows selection properly through the drop-down lists. In these course drag and drop of items works as expected.

      We are using Moodle 2.5+ (Build: 20130524) on SQL SERVER 2008 MS SQL 10.5.250 PHP 5.3.18 FreeTDS drivers.

      Upgrade error was reported in MDL-39869 (closed).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  11 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13