Hi Ankit,
There are some issues with this:
course/modlib.php
A1. I have concerns about passing the event name to edit_module_post_actions , yes that was the existing behaviour, but is it still what we should be doing here? I think you need to consider that further, passing $eventname when we now have a tightly defined API which might require one param for one event and not for other doesn't seem right. You are effectively coupling any events passed to this to always have the same required params. If the params ever vary between created and updated requirements then you are screwed. Please have some discussion about this and be certain you want to do it.
course/tests/courselib_test.php:
B1. In multiple places, you are retrieving the things to test against from the event itself. This is silly, let me show you an example why from test_course_module_updated_event():
$cm = $DB->get_record('course_modules', array('id' => $event->objectid));
$this->assertEquals($cm->id, $event->objectid);
You've tested exactly nothing there. You should be getting the $cm record explicitly when you are creating things, else we'll create useless tests which validate the event data is the same as the event data. I'm afraid thats probably a symptom of using those helper methods which already existed. I advise you to make those helper methods better and return something more robust to test against.
B2. $eventdata = new \stdClass(); doesn't seem correct to me. You are not in a namespace, no need to 'escape' it, right? (If there is, why aren't you doing it for moodle_url?)
B3. 'modulename' => 'Somename' It would be much better to use better 'test data' here, it improves the readability and helps demonstrate better what you are actually testing. That capitlisation makes it look like a lang string, where as its actually a module name (always lowercase). So why not use the real module name?
B4. In your get_record calls, please add MUST_EXIST's to make it clearer where the failure is in case of failure.
B5. Why in test_course_module_deleted_event() are you capturing the course module created event? (Oh I see, its the same problem as my first point). Please add a another point to B1.
All event files
C1. Related to B3, we need some documentation on what the $other[] data is supposed to be. In B3 I say that $this->other['modulename'], but I am not certain, I only made that assumption because you use it in get_url() as a module name. But then, what is $this->other['name']? Its not clear what these variables are supposed to be.
Task
Closed
Major
or deleted.
event mod_updated is currently triggered in update_moduleinfo() by calling edit_module_post_actions()