Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Themes
    • Labels:

      Description

      It should be using check_browser_version()

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            I discovered while testing this, that the sniffing and inclusion in theme_clean was also uncessary.

            Show
            poltawski Dan Poltawski added a comment - I discovered while testing this, that the sniffing and inclusion in theme_clean was also uncessary.
            Hide
            poltawski Dan Poltawski added a comment -

            TO INTEGRATOR: please cherry-pick to 2.5

            Show
            poltawski Dan Poltawski added a comment - TO INTEGRATOR: please cherry-pick to 2.5
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (25 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (25 & master), thanks!
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: Success!

            Tested in IE8 and IE10. Blocks appears normally (without responsiveness or rounded edges, but in the correct place).

            Show
            salvetore Michael de Raadt added a comment - Test result: Success! Tested in IE8 and IE10. Blocks appears normally (without responsiveness or rounded edges, but in the correct place).
            Hide
            poltawski Dan Poltawski added a comment -

            Feature: Thanks to our superb contributors
              In order to make Moodle better
              As an integrator
              I need to thank all our contributors
             
              Scenario: Dan thanks you all
                Given I log in as "dan"
                And I see "lots of fixed issues"
                When I follow "Close integrated issues"
                Then I should see "Lots of thanks to all our contributors"
            

            Your changes are upstream

            Show
            poltawski Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors   Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream
            Hide
            bawjaws David Scotson added a comment -

            Isn't this broken for IE10 and (at some point in the future ) IE11?

            The previous logic was IE 7 or IE 8, the new logic is any IE that isn't 9. The actual logic is "any IE less than 9 that we care about" so we could change it to "if IE8" and ignore 7 completely.

            Show
            bawjaws David Scotson added a comment - Isn't this broken for IE10 and (at some point in the future ) IE11? The previous logic was IE 7 or IE 8, the new logic is any IE that isn't 9. The actual logic is "any IE less than 9 that we care about" so we could change it to "if IE8" and ignore 7 completely.
            Hide
            bawjaws David Scotson added a comment -

            "Broken" in this case meaning: sending an unneccessary javascript file to the browser.

            Show
            bawjaws David Scotson added a comment - "Broken" in this case meaning: sending an unneccessary javascript file to the browser.
            Hide
            bawjaws David Scotson added a comment -

            Never mind, if you read the source of the function then it becomes clear that "check_browser_version" is really "check_browser_version_at_least".

            Show
            bawjaws David Scotson added a comment - Never mind, if you read the source of the function then it becomes clear that "check_browser_version" is really "check_browser_version_at_least".
            Hide
            poltawski Dan Poltawski added a comment -

            Yeah, its not a specularly great name.

            Show
            poltawski Dan Poltawski added a comment - Yeah, its not a specularly great name.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/13