Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Themes
    • Labels:
    • Rank:
      50708

      Description

      It should be using check_browser_version()

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          I discovered while testing this, that the sniffing and inclusion in theme_clean was also uncessary.

          Show
          Dan Poltawski added a comment - I discovered while testing this, that the sniffing and inclusion in theme_clean was also uncessary.
          Hide
          Dan Poltawski added a comment -

          TO INTEGRATOR: please cherry-pick to 2.5

          Show
          Dan Poltawski added a comment - TO INTEGRATOR: please cherry-pick to 2.5
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (25 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (25 & master), thanks!
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Tested in IE8 and IE10. Blocks appears normally (without responsiveness or rounded edges, but in the correct place).

          Show
          Michael de Raadt added a comment - Test result: Success! Tested in IE8 and IE10. Blocks appears normally (without responsiveness or rounded edges, but in the correct place).
          Hide
          Dan Poltawski added a comment -
          Feature: Thanks to our superb contributors
            In order to make Moodle better
            As an integrator
            I need to thank all our contributors
          
            Scenario: Dan thanks you all
              Given I log in as "dan"
              And I see "lots of fixed issues"
              When I follow "Close integrated issues"
              Then I should see "Lots of thanks to all our contributors"
          

          Your changes are upstream

          Show
          Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream
          Hide
          David Scotson added a comment -

          Isn't this broken for IE10 and (at some point in the future ) IE11?

          The previous logic was IE 7 or IE 8, the new logic is any IE that isn't 9. The actual logic is "any IE less than 9 that we care about" so we could change it to "if IE8" and ignore 7 completely.

          Show
          David Scotson added a comment - Isn't this broken for IE10 and (at some point in the future ) IE11? The previous logic was IE 7 or IE 8, the new logic is any IE that isn't 9. The actual logic is "any IE less than 9 that we care about" so we could change it to "if IE8" and ignore 7 completely.
          Hide
          David Scotson added a comment -

          "Broken" in this case meaning: sending an unneccessary javascript file to the browser.

          Show
          David Scotson added a comment - "Broken" in this case meaning: sending an unneccessary javascript file to the browser.
          Hide
          David Scotson added a comment -

          Never mind, if you read the source of the function then it becomes clear that "check_browser_version" is really "check_browser_version_at_least".

          Show
          David Scotson added a comment - Never mind, if you read the source of the function then it becomes clear that "check_browser_version" is really "check_browser_version_at_least".
          Hide
          Dan Poltawski added a comment -

          Yeah, its not a specularly great name.

          Show
          Dan Poltawski added a comment - Yeah, its not a specularly great name.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: