Moodle
  1. Moodle
  2. MDL-40003

Assignment submission comments are not restored

        Details

        • Testing Instructions:
          Hide
          1. Create a new mod_assign activity
          2. Enable the subplugin "Submission comments"
          3. Ensure one of the submission plugins is enabled (e.g. file submissions)
          4. Submit an assignment as a student
          5. After submitting, add a comment to your submission
          6. As a teacher, comment the submission too
          7. As Admin: Backup and restore the activity
          8. Make sure the comments are restored in the new activity
          Show
          Create a new mod_assign activity Enable the subplugin "Submission comments" Ensure one of the submission plugins is enabled (e.g. file submissions) Submit an assignment as a student After submitting, add a comment to your submission As a teacher, comment the submission too As Admin: Backup and restore the activity Make sure the comments are restored in the new activity
        • Affected Branches:
          MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
        • Pull from Repository:
        • Pull 2.6 Branch:
        • Pull 2.6 Diff URL:
        • Pull Master Branch:
          MDL-40003-master
        • Pull Master Diff URL:
        • Story Points (Obsolete):
          5
        • Sprint:
          FRONTEND Sprint 7

          Description

          If "Submission comments" is set to yes in an assignment and comments are made against a submission then when the course or activity is then backed up and restored with "Comments" and user data, the comments are not restored.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Sam Chaffee added a comment -

              Adding repo, branch and diff information for master. Let me know if I need to add anything additional.

              Show
              Sam Chaffee added a comment - Adding repo, branch and diff information for master. Let me know if I need to add anything additional.
              Hide
              Permalink
              Dan Poltawski added a comment -

              Sending this to the 'waiting for peer review' state.

              Show
              Dan Poltawski added a comment - Sending this to the 'waiting for peer review' state.
              Hide
              Permalink
              Adrian Greeve added a comment -

              [Y] Syntax
              [Y] Whitespace
              [-] Output
              [-] Language
              [-] Databases
              [N] Testing (instructions and automated tests)
              [-] Security
              [-] Documentation
              [N] Git
              [Y] Sanity check

              Hello Sam,

              The patch that you have provided works just fine. The only comments I have are about miscellaneous other areas:

              1. Could you please provide some testing instructions.
              2. Your git message is missing a component. See http://docs.moodle.org/dev/Peer_reviewing_checklist#Git
              3. Could you also please provide branches for 2.4 and 2.5

              Thanks for taking the time to provide a patch for this issue.

              Show
              Adrian Greeve added a comment - [Y] Syntax [Y] Whitespace [-] Output [-] Language [-] Databases [N] Testing (instructions and automated tests) [-] Security [-] Documentation [N] Git [Y] Sanity check Hello Sam, The patch that you have provided works just fine. The only comments I have are about miscellaneous other areas: Could you please provide some testing instructions. Your git message is missing a component. See http://docs.moodle.org/dev/Peer_reviewing_checklist#Git Could you also please provide branches for 2.4 and 2.5 Thanks for taking the time to provide a patch for this issue.
              Hide
              Permalink
              Frédéric Massart added a comment -

              Assigning this issue to myself because it is part of the Frontend Sprint.

              Show
              Frédéric Massart added a comment - Assigning this issue to myself because it is part of the Frontend Sprint.
              Hide
              Permalink
              Frédéric Massart added a comment -

              I am submitting for integration, keeping Adrian as the peer reviewer, because I did not change the patch at all. I only updated the testing instructions and the commit message.

              (I also think the patch is the right one. Not really a fan of the switch but that is not a reason to edit Sam's patch.)

              Cheers,
              Fred

              Show
              Frédéric Massart added a comment - I am submitting for integration, keeping Adrian as the peer reviewer, because I did not change the patch at all. I only updated the testing instructions and the commit message. (I also think the patch is the right one. Not really a fan of the switch but that is not a reason to edit Sam's patch.) Cheers, Fred
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Integrated (24, 25, 26 & master), thanks!

              Show
              Eloy Lafuente (stronk7) added a comment - Integrated (24, 25, 26 & master), thanks!
              Hide
              Permalink
              Dan Poltawski added a comment - - edited

              Hi Fred,

              I changed two things in the testing instructions:

              1/ Clarified the need for a submission plugin to be enabled to set a submission (not the default on 2.4)
              2/ A teacher does not have the capability to backup with user data, so I changed to be completed by admin

              Show
              Dan Poltawski added a comment - - edited Hi Fred, I changed two things in the testing instructions: 1/ Clarified the need for a submission plugin to be enabled to set a submission (not the default on 2.4) 2/ A teacher does not have the capability to backup with user data, so I changed to be completed by admin
              Hide
              Permalink
              Dan Poltawski added a comment -

              With those modifications made, it passes on 24, 25, 26 and master - thanks Fred

              Show
              Dan Poltawski added a comment - With those modifications made, it passes on 24, 25, 26 and master - thanks Fred
              Hide
              Permalink
              Frédéric Massart added a comment -

              Thanks Dan.

              Show
              Frédéric Massart added a comment - Thanks Dan.
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Thanks for the code, its now upstream!

              Heres a fun trick to try in the spirit of Friday the 13th.
              I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

              Show
              Sam Hemelryk added a comment - Thanks for the code, its now upstream! Heres a fun trick to try in the spirit of Friday the 13th. I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Agile