Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40006

User selector does not hide non-matching users correctly in Safari

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.5, 2.7.1
    • Fix Version/s: 2.6.6, 2.7.3
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      Bad news: This needs to be tested in all browsers. (Well, Firefox, Chrome, Safari and IE.)

      1. You need a course with some enrolled users and a quiz (no need to add questions).
      2. In the quiz, go to Quiz administration -> User overrides.
      3. Click to add a new override.
      4. You are playing with the search widget to filter the list of users. Ensure it works, hiding and re-showing users as the don't or do match the search.
      Show
      Bad news: This needs to be tested in all browsers. (Well, Firefox, Chrome, Safari and IE.) You need a course with some enrolled users and a quiz (no need to add questions). In the quiz, go to Quiz administration -> User overrides. Click to add a new override. You are playing with the search widget to filter the list of users. Ensure it works, hiding and re-showing users as the don't or do match the search.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_25_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      The moodle forms 'searchableselector' element does not render consistently for webkit based browsers and IE. In Firefox the filtered elements are correctly 'hidden' from view as the user types a search string, however in Chrome the elements are only greyed out and remain visible. On a small list this is not a big issue, but this widget is used on lists that contain class rosters and in those cases the functionality of this widget is diminished.

      This happens specifically in 'lib/forms/searchableselector.js' – the select option elements are being given a style of 'display:none' which webkit browsers do not render. The way to handle this so that it's consistent across all browsers is to dynamically add/remove the option node.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              alroman Alfonso Roman
              Peer reviewer:
              Andrew Nicols
              Integrator:
              Dan Poltawski
              Tester:
              Jetha Chan
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              10 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14