Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40009

Incorrect variable name passed to setType causing warning to display in 2.5 onwards

    Details

    • Testing Instructions:
      Hide
      1. Log in as an administrator.
      2. Go to a course
      3. View the profile of any other user in that course
      4. Click on 'Notes' on the left side.
      5. Click 'Add a new note'.
      6. Make sure you do not get any setType errors.
      7. Post something and ensure it posts successfully.
      Show
      Log in as an administrator. Go to a course View the profile of any other user in that course Click on 'Notes' on the left side. Click 'Add a new note'. Make sure you do not get any setType errors. Post something and ensure it posts successfully.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-40009_master

      Description

      1. Log in as an administrator.
      2. View the profile of any other user.
      3. Click on 'Notes' on the left side.
      4. Click 'Add a new note'.
      5. Notice you get a warning message regarding setType (in 2.5 onwards).

        Gliffy Diagrams

          Activity

          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          Thanks Mark,

          Patch look spot-on, pushing it for integration.

          Show
          rajeshtaneja Rajesh Taneja added a comment - Thanks Mark, Patch look spot-on, pushing it for integration.
          Hide
          poltawski Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Mark this has been integrated now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Mark this has been integrated now.
          Hide
          poltawski Dan Poltawski added a comment -

          Hurray, it passes.

          Show
          poltawski Dan Poltawski added a comment - Hurray, it passes.
          Hide
          marina Marina Glancy added a comment -

          Thanks for your awesome work! This has now become a part of Moodle.

          Closing as fixed!

          Show
          marina Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/13