Moodle
  1. Moodle
  2. MDL-40009

Incorrect variable name passed to setType causing warning to display in 2.5 onwards

    Details

    • Rank:
      50758

      Description

      1. Log in as an administrator.
      2. View the profile of any other user.
      3. Click on 'Notes' on the left side.
      4. Click 'Add a new note'.
      5. Notice you get a warning message regarding setType (in 2.5 onwards).

        Activity

        Hide
        Rajesh Taneja added a comment -

        Thanks Mark,

        Patch look spot-on, pushing it for integration.

        Show
        Rajesh Taneja added a comment - Thanks Mark, Patch look spot-on, pushing it for integration.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks Mark this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Mark this has been integrated now.
        Hide
        Dan Poltawski added a comment -

        Hurray, it passes.

        Show
        Dan Poltawski added a comment - Hurray, it passes.
        Hide
        Marina Glancy added a comment -

        Thanks for your awesome work! This has now become a part of Moodle.

        Closing as fixed!

        Show
        Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: