Moodle
  1. Moodle
  2. MDL-40010

Fix issue with a debugging message being displayed when deleting a note

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Administration, Other
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an administrator.
      2. View the profile of any other user.
      3. Click on 'Notes' on the left side.
      4. Click 'Add a new note'.
      5. Click to delete the note and ensure no debugging message is displayed and the note deletes successfully.
      Show
      Log in as an administrator. View the profile of any other user. Click on 'Notes' on the left side. Click 'Add a new note'. Click to delete the note and ensure no debugging message is displayed and the note deletes successfully.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-40010_master

      Description

      1. Log in as an administrator.
      2. View the profile of any other user.
      3. Click on 'Notes' on the left side.
      4. Click 'Add a new note'.
      5. Delete the note and see that the following debugging message shows -

      'Warning: providing note_delete with a note object would improve performance.'

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Mark Nelson added a comment -

            This does not affect Moodle 2.3 or 2.4 as the function note_delete was only altered in Moodle 2.5.

            Show
            Mark Nelson added a comment - This does not affect Moodle 2.3 or 2.4 as the function note_delete was only altered in Moodle 2.5.
            Hide
            Mark Nelson added a comment -

            Note: Raj, you will see debugging messages regarding the setType function; that has been fixed in MDL-40009

            Show
            Mark Nelson added a comment - Note: Raj, you will see debugging messages regarding the setType function; that has been fixed in MDL-40009
            Hide
            Rajesh Taneja added a comment -

            Thanks for fixing this Mark,

            I think it will be nice to backport this, before pushing it for integration.

            Show
            Rajesh Taneja added a comment - Thanks for fixing this Mark, I think it will be nice to backport this, before pushing it for integration.
            Hide
            Mark Nelson added a comment - - edited

            Hi Raj, can't backport this as the function was changed in 2.5 to accept a note object, where as in earlier versions it was strictly a note id. No idea why this was not addressed in MDL-30072 though.

            Show
            Mark Nelson added a comment - - edited Hi Raj, can't backport this as the function was changed in 2.5 to accept a note object, where as in earlier versions it was strictly a note id. No idea why this was not addressed in MDL-30072 though.
            Hide
            Rajesh Taneja added a comment -

            Aha, Sorry missed your first comment.

            Show
            Rajesh Taneja added a comment - Aha, Sorry missed your first comment.
            Hide
            Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Mark Nelson added a comment -

            Note to integrator: this should be integrated into 2.5 and master.

            Show
            Mark Nelson added a comment - Note to integrator: this should be integrated into 2.5 and master.
            Hide
            Dan Poltawski added a comment -

            Integrated to master and 25 - thanks guys

            Show
            Dan Poltawski added a comment - Integrated to master and 25 - thanks guys
            Hide
            Adrian Greeve added a comment -

            Tested on the master integration branch.
            No debugging messages were displayed while creating or deleting a note about a user.
            Test passed.

            Show
            Adrian Greeve added a comment - Tested on the master integration branch. No debugging messages were displayed while creating or deleting a note about a user. Test passed.
            Hide
            Marina Glancy added a comment -

            Thanks for your awesome work! This has now become a part of Moodle.

            Closing as fixed!

            Show
            Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: