Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40013

Make question_type::save_hints more suitable for child classes

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a question without parts (shortanswer for example), enter several hints and save it.
      2. Re-open created question for editing and make sure all hints was correctly saved.
      3. Create a question with parts (match for example), enter several hints and check several hint options. In last hint don't write text, just check hint options.
      4. Re-open created question for editing and make sure all hints was correctly saved.

      Show
      1. Create a question without parts (shortanswer for example), enter several hints and save it. 2. Re-open created question for editing and make sure all hints was correctly saved. 3. Create a question with parts (match for example), enter several hints and check several hint options. In last hint don't write text, just check hint options. 4. Re-open created question for editing and make sure all hints was correctly saved.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40013_master

      Description

      Overloading of save_hints() method involves duplicating many strings of code.

      This could be avoided by adding 3 methods, called from it, designed for overloading.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              oa_sychev Oleg Sychev
              Reporter:
              oa_sychev Oleg Sychev
              Peer reviewer:
              Tim Hunt
              Integrator:
              Dan Poltawski
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/13