Moodle
  1. Moodle
  2. MDL-40018

sky_high has a different footer on admin pages

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.5
        • Fix Version/s: 2.3.8, 2.4.5, 2.5.1
        • Component/s: Themes
        • Labels:
        • Testing Instructions:
          Hide
          1. Select Sky High theme
          2. Note what the footer looks like normally, sky-blue image with seagulls flying and grey gradient bar along the bottom edge that contains a footnote on the left (optional custom setting) and login/logout on the right.
          3. Select any Admin page like Theme settings
          4. TEST to see that the footer is displayed normally and nothing like the attached image
          Show
          Select Sky High theme Note what the footer looks like normally, sky-blue image with seagulls flying and grey gradient bar along the bottom edge that contains a footnote on the left (optional custom setting) and login/logout on the right. Select any Admin page like Theme settings TEST to see that the footer is displayed normally and nothing like the attached image
        • Affected Branches:
          MOODLE_25_STABLE
        • Fixed Branches:
          MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-40018_master
        • Pull Master Diff URL:

          Description

          Footer displays incorrectly in admin pages only - see image

            Gliffy Diagrams

              Issue Links

              Testing discovered

              Improvement - An enhancement to an existing Moodle feature. MDL-39835 Theme sky_high: odd footer at higher screen resolutions

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Dan Poltawski added a comment -

                The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                TIA and ciao

                Show
                Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                Hide
                Permalink
                Mary Evans added a comment -

                REBASED ALL BRANCHES

                Show
                Mary Evans added a comment - REBASED ALL BRANCHES
                Hide
                Permalink
                Dan Poltawski added a comment -

                Integrated to master, 25, 24 and 23.

                Thanks a lot Mary.

                Show
                Dan Poltawski added a comment - Integrated to master, 25, 24 and 23. Thanks a lot Mary.
                Hide
                Permalink
                Adrian Greeve added a comment -

                tested on 2.5, 2.4, 2.3, and master integration branches.
                The footer is consistent on all pages using the sky_high theme.
                Test passed.

                Show
                Adrian Greeve added a comment - tested on 2.5, 2.4, 2.3, and master integration branches. The footer is consistent on all pages using the sky_high theme. Test passed.
                Hide
                Permalink
                Marina Glancy added a comment -

                Thanks for your awesome work! This has now become a part of Moodle.

                Closing as fixed!

                Show
                Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!
                Hide
                Permalink
                Mary Evans added a comment -

                Thanks everyone!

                Show
                Mary Evans added a comment - Thanks everyone!

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: