Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34311 Improve debugging when using default cleaning
  3. MDL-40022

Fix missing calls to setType in course criteria settings

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a site level badge.
      2. Add course set completion criteria.
      3. Select some courses and proceed.
      3. No setType() warning should appear.

      Show
      1. Create a site level badge. 2. Add course set completion criteria. 3. Select some courses and proceed. 3. No setType() warning should appear.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:

      Description

      Did you remember to call setType() for 'grade_14'? Defaulting to PARAM_RAW cleaning.

      line 1303 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 78 of /badges/criteria_settings.php: call to moodleform->moodleform()

      To replicate:

      1. add a new badge
      2. add badge criteria for completing a set of course

        Attachments

          Activity

            People

            Assignee:
            ybozhko Yuliya Bozhko
            Reporter:
            rwijaya Rossiani Wijaya
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Sam Hemelryk
            Tester:
            Michael de Raadt
            Participants:
            Component watchers:
            Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/13