Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40047

Replace add_to_log with an event trigger - mod_feedback

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a feedback activity if you don't have one, with a few questions spread over multiple pages.(Set 'Record user names' to "user's name will be logged" for the feedback)
      2. As a student submit a response and make sure an entry is created in the logs.
      3. As another student, start a response, submit the first page and then logout.
      4. Log back in as the same student and finish and submit the response. Make sure a log entry is created for it as before.
      5. As admin, delete a student's response. Make sure an entry is created for the same.
      6. Visit the view.php and index.php of the feedback module. Make sure an log entry is created for each of these visits.
      7. Run unitests in mod/feedback/tests/ . Make sure they all pass.
      Show
      Create a feedback activity if you don't have one, with a few questions spread over multiple pages.(Set 'Record user names' to "user's name will be logged" for the feedback) As a student submit a response and make sure an entry is created in the logs. As another student, start a response, submit the first page and then logout. Log back in as the same student and finish and submit the response. Make sure a log entry is created for it as before. As admin, delete a student's response. Make sure an entry is created for the same. Visit the view.php and index.php of the feedback module. Make sure an log entry is created for each of these visits. Run unitests in mod/feedback/tests/ . Make sure they all pass.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40047-master
    • Pull Master Diff URL:
    • Story Points:
      20
    • Sprint:
      BACKEND Sprint 5

      Description

      Replace the add_to_log calls for the following area, with a call to the get_legacy_logdata function in the event class.

      mod/feedback (6 calls)
      /mod/feedback/complete_guest.php:213: add_to_log($course->id,'feedback', 'startcomplete', 'view.php?id='.$cm->id, $feedback->id);
      /mod/feedback/index.php:43: add_to_log($course->id, 'feedback', 'view all', $url->out(false), $course->id);
      /mod/feedback/delete_completed.php:79: add_to_log($course->id, 'feedback', 'delete', 'view.php?id='.$cm->id, $feedback->id, $cm->id);
      /mod/feedback/complete.php:269: add_to_log($course->id, 'feedback', 'submit', 'view.php?id='.$cm->id, $feedback->id, $cm->id, $userid);
      /mod/feedback/complete.php:213: add_to_log($course->id, 'feedback', 'startcomplete', 'view.php?id='.$cm->id, $feedback->id, $cm->id, $userid);
      /mod/feedback/view.php:100: add_to_log($course->id, 'feedback', 'view', 'view.php?id='.$cm->id, $feedback->id, $cm->id);

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41833 SetType warnings in feedback when trying to delete a response

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41894 Strict warning when viewing a non anonymous response in feedback

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42194 Underscores banned in string identifiers?

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Jérôme Mouneyrac
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13