Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40053

Replace add_to_log with an event trigger - notes

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: Events API, Logging
    • Labels:
    • Testing Instructions:
      Hide
      1. Run unit tests in /notes/tests/generator_test.php and /notes/tests/events_test.php and make sure they pass.
      2. Create/update/delete a note (all three types site/course/personal).
      3. view notes
      4. Make sure for action 2 and 3 log entries with correct data is created as before and no error is encountered during the process.
      Show
      Run unit tests in /notes/tests/generator_test.php and /notes/tests/events_test.php and make sure they pass. Create/update/delete a note (all three types site/course/personal). view notes Make sure for action 2 and 3 log entries with correct data is created as before and no error is encountered during the process.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-40053-master
    • Story Points:
      13
    • Sprint:
      BACKEND Sprint 5

      Description

      Replace the add_to_log calls for the following area, with a call to the get_legacy_logdata function in the event class.

      notes

      • /notes/index.php:64: add_to_log($courseid, 'notes', 'view', 'index.php?course='.$courseid.'&user='.$userid, 'view notes');
      • /notes/lib.php:107: add_to_log($note->courseid, 'notes', 'add', $logurl, 'add note');
      • /notes/lib.php:114: add_to_log($note->courseid, 'notes', 'update', $logurl , 'update note');
      • /notes/lib.php:134: add_to_log($note->courseid, 'notes', 'delete', $logurl, 'delete note');

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13