Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40079

Hardcoded timeout parameter in the repository plugin

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.7, 2.4.4, 2.5
    • Fix Version/s: 2.7
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide
      1. Edit "Common repository settings" and set
        • repositorygetfiletimeout = 1
        • repositorysyncfiletimeout = 1
        • repositorysyncimagetimeout = 1
      2. Create dropbox repo
      3. Go to private files and add a large image file (>5MB) from dropbox and it should fail with time out error
      4. Edit "Common repository settings" and set
        • repositorygetfiletimeout = 50
      5. Repeat steps to get file from dropbox and it should get file without problem.
      6. Repeat above test steps for box.net and equalla (if possible).
      Show
      Edit "Common repository settings" and set repositorygetfiletimeout = 1 repositorysyncfiletimeout = 1 repositorysyncimagetimeout = 1 Create dropbox repo Go to private files and add a large image file (>5MB) from dropbox and it should fail with time out error Edit "Common repository settings" and set repositorygetfiletimeout = 50 Repeat steps to get file from dropbox and it should get file without problem. Repeat above test steps for box.net and equalla (if possible).
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      wip-mdl-40079
    • Story Points:
      40
    • Sprint:
      BACKEND Sprint 6

      Description

      Hi,
      I found hardcoded timeout parameters in moodle/repository/lib.php

      This timeout results that I can't get a 25 MB video file from Dropbox to Moodle. This is a blocker for the Dropbox plugin and for all other repositories.

      The parameter should be configurable to higher values in config.php.
      If there is no setting in config.php then Moodle uses the default timeout.
      The best thing would be if the Moodle admin can set the timeout in the repository settings moodle/admin/settings.php?section=managerepositoriescommon

      Best regards, Ralf
      moodleSCHULE - Moodle Partner

      /** Timeout in seconds for downloading the external file into moodle */
      const GETFILE_TIMEOUT = 30;
      /** Timeout in seconds for syncronising the external file size */
      const SYNCFILE_TIMEOUT = 1;
      /** Timeout in seconds for downloading an image file from external repository during syncronisation */
      const SYNCIMAGE_TIMEOUT = 3;
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              krause Ralf Krause
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Sam Hemelryk
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              3 Vote for this issue
              Watchers:
              14 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14