Moodle
  1. Moodle
  2. MDL-40080

Remove publishonmoodleorg and shareonmoodleorg

    Details

    • Rank:
      50808

      Description

      As Helen Foster noticed recently, the core_hub subsystem still provides strings

      $string['publishonmoodleorg'] = 'Publish on MOOCH';
      $string['shareonmoodleorg'] = 'Upload this course to MOOCH';
      

      that were never actually used. In AMOS, they have been greylisted since Moodle 2.0. I believe it is safe to remove them from all supported STABLE branches as well as from the master branch (even though the policy is to remove strings from master only, this is an exception as the strings were never actually used).

        Activity

        Hide
        David Mudrak added a comment -

        Submitting for integration.

        Dear iTeam - if you agree with me, please cherry pick the commit into STABLEs as well. Thanks in advance.

        Show
        David Mudrak added a comment - Submitting for integration. Dear iTeam - if you agree with me, please cherry pick the commit into STABLEs as well. Thanks in advance.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Integrated to master, 25, 24 and 23. Thanks david.

        Show
        Dan Poltawski added a comment - Integrated to master, 25, 24 and 23. Thanks david.
        Hide
        Dan Poltawski added a comment -

        git greped and confirmed these strings are not used.

        Show
        Dan Poltawski added a comment - git greped and confirmed these strings are not used.
        Hide
        Marina Glancy added a comment -

        Thanks for your awesome work! This has now become a part of Moodle.

        Closing as fixed!

        Show
        Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: