Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40093

Offline assignment grading summary screen shows count of drafts

    Details

    • Testing Instructions:
      Hide

      1 Create an assignment
      2 Set all submission settings to No (ie create an offline assignment type)
      3. Set 'Require students click submit button' to Yes
      4. Save and display
      5. The grading summary table only shows number of participants, due date, time remaining (no drafts)

      Show
      1 Create an assignment 2 Set all submission settings to No (ie create an offline assignment type) 3. Set 'Require students click submit button' to Yes 4. Save and display 5. The grading summary table only shows number of participants, due date, time remaining (no drafts)
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:

      Description

      For teachers, the grading summary screen for offline assignments shows the following: (as an example)

      Participants: 10
      Drafts: 0

      It makes no sense to display number of drafts, as students can't submit anything. This row should be removed.

        Gliffy Diagrams

          Activity

          Hide
          corleone Raymond Antonio added a comment -

          Hi Damyon,

          Thought to request you to peer review a fix I put up on this tracker for this bug. Please let me know what you think if you have a chance to review this. I look forward to your feedback and thank you in Advance.

          Best regards,

          Raymond

          Show
          corleone Raymond Antonio added a comment - Hi Damyon, Thought to request you to peer review a fix I put up on this tracker for this bug. Please let me know what you think if you have a chance to review this. I look forward to your feedback and thank you in Advance. Best regards, Raymond
          Hide
          damyon Damyon Wiese added a comment -

          Thanks Raymond, looks perfect!

          I'll send this straight for integration.

          Show
          damyon Damyon Wiese added a comment - Thanks Raymond, looks perfect! I'll send this straight for integration.
          Hide
          corleone Raymond Antonio added a comment -

          Thanks Damyon. made my day

          Show
          corleone Raymond Antonio added a comment - Thanks Damyon. made my day
          Hide
          marina Marina Glancy added a comment -

          Thank you, this has been integrated in 2.3, 2.4, 2.5 and master.

          Raymond, I had to change the commit messages - I removed the "Conflicts" message and changed the branch name to just the issue number.

          Please when you write commit message start it with the issue number followed by space (semicolon is also acceptable but space is better). Thanks again.

          Show
          marina Marina Glancy added a comment - Thank you, this has been integrated in 2.3, 2.4, 2.5 and master. Raymond, I had to change the commit messages - I removed the "Conflicts" message and changed the branch name to just the issue number. Please when you write commit message start it with the issue number followed by space (semicolon is also acceptable but space is better). Thanks again.
          Hide
          corleone Raymond Antonio added a comment -

          Thank you Marina and Damyon. Yes will remember that next time. Have a lovely day.

          Show
          corleone Raymond Antonio added a comment - Thank you Marina and Damyon. Yes will remember that next time. Have a lovely day.
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks Raymond, tested succesfully on master, 25, 24 and 23.

          And Kudos, Damyon for the forms rejig in 2.5, because I got lost in 2.4 and 2.3 now i'm used to 2.5!

          Show
          poltawski Dan Poltawski added a comment - Thanks Raymond, tested succesfully on master, 25, 24 and 23. And Kudos, Damyon for the forms rejig in 2.5, because I got lost in 2.4 and 2.3 now i'm used to 2.5!
          Hide
          damyon Damyon Wiese added a comment -

          a single bug fix
          a drop in a waterfall
          hear the mighty roar

          Thanks for your contribution!

          Show
          damyon Damyon Wiese added a comment - a single bug fix a drop in a waterfall hear the mighty roar Thanks for your contribution!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/13