Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40096

Javascript error prevents file tree display in assignment grading table

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Major
          • Resolution: Fixed
          • Affects Version/s: 2.4.3
          • Fix Version/s: 2.4.8, 2.5.4, 2.6.1
          • Component/s: Assignment
          • Labels:
          • Testing Instructions:
            Hide

            Just testing for regressions because the reported bug is hard to reproduce.

            1. Create an assignment allowing file submissions.
            2. For multiple students, upload some file submissions.
            3. Login as a teacher and view the grading table
            4. Verify that the files from all students are displayed correctly.
            Show
            Just testing for regressions because the reported bug is hard to reproduce. Create an assignment allowing file submissions. For multiple students, upload some file submissions. Login as a teacher and view the grading table Verify that the files from all students are displayed correctly.
          • Affected Branches:
            MOODLE_24_STABLE
          • Fixed Branches:
            MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-40096-master
          • Pull Master Diff URL:

            Description

            When looking at the grading table, some submission and response files are missing even though they exist and can be seen when clicking Grade. I don't know how to attach a screenshot to this bug tracker so I am linking to one in my post in the Moodle forum:

            https://moodle.org/mod/forum/discuss.php?d=229557

            I notice that some files look like they are following a tree structure while others look like list items with bullet points. Minimising and maximising different columns can cause some files to come back, then others will be missing.

            On 2.4.3 it happens on all browsers. This doesn't happen in our other Moodle installs of 2.4.3. We recently migrated from 1.9 to 2.4. and upgraded all our assignments.
            Can anyone help?
            Thanks

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is duplicated by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40023 Assignment - grading - some uploaded files not visible due to duplicate IDs in DIV tags on Windows 2008 R2

                  • Major - Major loss of function, incorrect output
                  • Closed

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43120 Erratic display of file submissions column when grading assignment

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    asalem Adam Salem added a comment -

                    I'm also experiencing this issue.

                    It appears to be PHP related. On a server running PHP5.3 the assignments are fine, on one using PHP5.4, I experience the issues detailed here.

                    Is there likely to be a fix for this?

                    Show
                    asalem Adam Salem added a comment - I'm also experiencing this issue. It appears to be PHP related. On a server running PHP5.3 the assignments are fine, on one using PHP5.4, I experience the issues detailed here. Is there likely to be a fix for this?
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Well - I can't reproduce it - but I suspect it is due to running moodle on a reasonably fast VM where microtime() is a bit broken (repeatedly returns the same result) which causes uniqid() to be non-unique. By hacking my code and changing the call to uniqid() to '1' I can reproduce the screenshots provided.

                    Posting a solution that replaces the call to uniqid() in mod_assign with html_writer::random_id() which uses a static counter to guarantee different results even when uniqid itself is broken.

                    Show
                    damyon Damyon Wiese added a comment - Well - I can't reproduce it - but I suspect it is due to running moodle on a reasonably fast VM where microtime() is a bit broken (repeatedly returns the same result) which causes uniqid() to be non-unique. By hacking my code and changing the call to uniqid() to '1' I can reproduce the screenshots provided. Posting a solution that replaces the call to uniqid() in mod_assign with html_writer::random_id() which uses a static counter to guarantee different results even when uniqid itself is broken.
                    Hide
                    Permalink
                    asalem Adam Salem added a comment -

                    Hi Damyon,

                    I've applied your fix to 2 Moodle 2.5 servers where the issue was replicating consistently and the issue no longer replicates... Looks like the fix works!

                    Thanks for this one, was the root of a lot of frustration for staff.

                    Show
                    asalem Adam Salem added a comment - Hi Damyon, I've applied your fix to 2 Moodle 2.5 servers where the issue was replicating consistently and the issue no longer replicates... Looks like the fix works! Thanks for this one, was the root of a lot of frustration for staff.
                    Hide
                    Permalink
                    skodak Petr Skoda added a comment -

                    +1

                    Show
                    skodak Petr Skoda added a comment - +1
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks Damyon - this has been integrated now.

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks Damyon - this has been integrated now.
                    Hide
                    Permalink
                    markn Mark Nelson added a comment -

                    Thanks Damyon, works as expected.

                    Show
                    markn Mark Nelson added a comment - Thanks Damyon, works as expected.
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Twas the week before Christmas,
                    And all though HQ
                    Devs were scrambling to finish peer review.
                    They sent all their issues,
                    and rushed out the door -
                    "To the beach!" someone heard them roar!

                    This issue has been released upstream. Thanks!

                    Show
                    damyon Damyon Wiese added a comment - Twas the week before Christmas, And all though HQ Devs were scrambling to finish peer review. They sent all their issues, and rushed out the door - "To the beach!" someone heard them roar! This issue has been released upstream. Thanks!

                      People

                      • Votes:
                        1 Vote for this issue
                        Watchers:
                        8 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          13/Jan/14