[MDL-40097] Course completion role criteria causes fatal error - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.4.5, 2.6.6, 2.7.3, 2.8
Fix Version/s: 2.7.4, 2.8.2
Component/s: Course completion
Labels:
- CatalystIT
- ci
- partner
- triaged
- ui_change

Affected Branches:
MOODLE_24_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/abgreeve/moodle.git
Pull Master Branch:
wip-~~MDL-40097~~-master
Pull Master Diff URL:
https://github.com/abgreeve/moodle/compare/eb1dc9f...wip-MDL-40097-master
Testing Instructions:
Hide

Normal testing

Enable completion tracking and Enable conditional access [Site administration ► Advanced features].

Create a new course. Make sure that completion tracking is enabled.

Create some activities and set up requirements for completion.

Create two roles with the capability moodle/course:markcomplete.

[Site administration ► Users ► Permissions ► Define roles]

Use a 'Teacher' archetype / role.

Check that moodle/course:markcomplete is set to Allow.

Go to the course and check out 'Course completion' [Courses ► Miscellaneous ► {your course}
► Course completion].

Expand 'Condition: Manual completion by others' and check the boxes next to the roles that you created.

Add the Course Completion Status block.

Enrol yourself as a student.

Confirm the course completion status block shows your status in conditions

Make a backup of the course without user data.

Restore the backup of the course into a new course.

Enrol students into the backed up course.

Log in as a student.

Try to view the course.

Old behaviour:
Completion status block and completion report throw errors

New behaviour:
They don't! Confirm by checking in the new course's completion settings that the role you added in the original course is still checked.

Bonus:

Restore backup on a different Moodle install and confirm working.

Between backing up and restoring, delete the two roles you created, recreating new roles with the same shortnames. Check the restore and course block still work and now point to the new roles.

Regression testing

Create a backup file before this patch has been implemented.

Restore the file after the patch has been implemented and check for errors.
Show
Normal testing Enable completion tracking and Enable conditional access [Site administration ► Advanced features] . Create a new course. Make sure that completion tracking is enabled. Create some activities and set up requirements for completion. Create two roles with the capability moodle/course:markcomplete. [Site administration ► Users ► Permissions ► Define roles] Use a 'Teacher' archetype / role. Check that moodle/course:markcomplete is set to Allow. Go to the course and check out 'Course completion' [Courses ► Miscellaneous ► {your course} ► Course completion]. Expand 'Condition: Manual completion by others' and check the boxes next to the roles that you created. Add the Course Completion Status block. Enrol yourself as a student. Confirm the course completion status block shows your status in conditions Make a backup of the course without user data. Restore the backup of the course into a new course. Enrol students into the backed up course. Log in as a student. Try to view the course. Old behaviour: Completion status block and completion report throw errors New behaviour: They don't! Confirm by checking in the new course's completion settings that the role you added in the original course is still checked. Bonus: Restore backup on a different Moodle install and confirm working. Between backing up and restoring, delete the two roles you created, recreating new roles with the same shortnames. Check the restore and course block still work and now point to the new roles. Regression testing Create a backup file before this patch has been implemented. Restore the file after the patch has been implemented and check for errors.

Sprint:
BACKEND Sprint 19
Issue size:
Small

Description

Hi there,

I'm using Moodle 2.4 on a test site.

I've got a large course with many activities with completion criteria set. I'm using the Flexible Sections course format to structure things.

When I added the Course Completion block to the course I started getting the error:

Coding error detected, it must be fixed by a programmer: PHP catchable fatal error

I was able to turn on debugging and have identified the course completion block as the issue. When it's disabled the error goes.

Here's the debug info:

Debug info: Argument 1 passed to role_get_name() must be an instance of stdClass, boolean given, called in [dirroot]/completion/criteria/completion_criteria_role.php on line 126 and defined
Error code: codingerror
Stack trace:
line 406 of /lib/setuplib.php: coding_exception thrown
line 4458 of /lib/accesslib.php: call to default_error_handler()
line 126 of /completion/criteria/completion_criteria_role.php: call to role_get_name()
line 141 of /blocks/completionstatus/block_completionstatus.php: call to completion_criteria_role->get_title()
line 284 of /blocks/moodleblock.class.php: call to block_completionstatus->get_content()
line 232 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()
line 953 of /lib/blocklib.php: call to block_base->get_content_for_output()
line 1005 of /lib/blocklib.php: call to block_manager->create_block_contents()
line 353 of /lib/blocklib.php: call to block_manager->ensure_content_created()
line 34 of /theme/standardtotara/layout/general.php: call to block_manager->region_has_content()
line 806 of /lib/outputrenderers.php: call to include()
line 734 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
line 240 of /course/view.php: call to core_renderer->header()

Attachments

Issue Links

has a non-specific relationship to

MDL-39976 Completion tracking role not getting restored correctly. Breaking course access for some.

Closed

has been marked as being related by

MDL-51183 If a course has blocks which have had Guest and/or Authenticated user roles removed, when backed up and restored, the new course retains those removed roles

Open

MDL-44479 Badge role criteria is not getting properly restored when course is restored

Closed

Activity

People

Assignee:: Aaron Barnes

Reporter:: Mark Berthelemy

Peer reviewer:: Adrian Greeve

Integrator:: Andrew Lyons

Tester:: Simey Lameze

Participants:: Aaron Barnes, Aditya Pratap Singh, Adrian Greeve, Andrew Lyons, Benjamin Wright, Brent Sawatzky, CiBoT, Dan Poltawski, David Richards, Eloy Lafuente (stronk7), Howard Miller, Mark Berthelemy, Mike Turico, Neil Simon, Paul Vaughan, Rodolfo Siles, Simey Lameze, Yuliya Bozhko

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 21 Vote for this issue

Watchers:: 23 Start watching this issue

Dates

Created:: 07/Jun/13 11:17 PM

Updated:: 28/Jul/18 1:16 AM

Resolved:: 09/Jan/15 6:17 AM

Fix Release Date:: 12/Jan/15